You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by xkli <gi...@git.apache.org> on 2017/04/06 07:16:02 UTC

[GitHub] incubator-weex pull request #216: * [android] update imageView

GitHub user xkli opened a pull request:

    https://github.com/apache/incubator-weex/pull/216

    * [android] update imageView

    @zshshr 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xkli/incubator-weex 0.11-dev-image2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #216
    
----
commit 6f861949db2fab33079cfec5c8c13040fec9b8d4
Author: xkli <56...@qq.com>
Date:   2017-04-01T06:39:21Z

    * [android] update imageView

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #216: * [android] update imageView

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/216
  
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true" data-kind="Error">
              4 Errors
          </th>
         </tr>
      </thead>
      <tbody>
        <tr>
          <td>:no_entry_sign:</td>
          <td data-sticky="false"><strong><a href="https://github.com/xkli/incubator-weex/blob/6f861949db2fab33079cfec5c8c13040fec9b8d4/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50</a></strong>: incompatible pointer types sending \u2018NSNumber *\u2019 to parameter of type \u2018NSIndexPath * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types]  <br /><code>
                [_headerToIndexTable setObject:@(idx) forKey:controller.headerComponent];
    </code></td>
        </tr>
        <tr>
          <td>:no_entry_sign:</td>
          <td data-sticky="false"><strong><a href="https://github.com/xkli/incubator-weex/blob/6f861949db2fab33079cfec5c8c13040fec9b8d4/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L50</a></strong>: incompatible pointer types sending \u2018WXHeaderComponent *\u2019 to parameter of type \u2018WXCellComponent * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types]  <br /><code>
                [_headerToIndexTable setObject:@(idx) forKey:controller.headerComponent];
    </code></td>
        </tr>
        <tr>
          <td>:no_entry_sign:</td>
          <td data-sticky="false"><strong><a href="https://github.com/xkli/incubator-weex/blob/6f861949db2fab33079cfec5c8c13040fec9b8d4/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114</a></strong>: incompatible pointer types sending \u2018WXHeaderComponent *\u2019 to parameter of type \u2018WXCellComponent * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types]  <br /><code>
        NSNumber *index = [_headerToIndexTable objectForKey:header];
    </code></td>
        </tr>
        <tr>
          <td>:no_entry_sign:</td>
          <td data-sticky="false"><strong><a href="https://github.com/xkli/incubator-weex/blob/6f861949db2fab33079cfec5c8c13040fec9b8d4/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114">ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerDataController.m#L114</a></strong>: incompatible pointer types initializing \u2018NSNumber *\u2019 with an expression of type \u2018NSIndexPath * _Nullable\u2019 [-Werror,-Wincompatible-pointer-types]  <br /><code>
        NSNumber *index = [_headerToIndexTable objectForKey:header];
    </code></td>
        </tr>
      </tbody>
    </table>
    
    <p align="right" data-meta="generated_by_danger">
      Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #216: * [android] update imageView

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---