You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by radarwave <gi...@git.apache.org> on 2015/12/20 15:25:25 UTC
[GitHub] incubator-hawq pull request: HAWQ-266. Check if krb_server_keyfile...
GitHub user radarwave opened a pull request:
https://github.com/apache/incubator-hawq/pull/203
HAWQ-266. Check if krb_server_keyfile exist in hawq-site.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radarwave/incubator-hawq HAWQ-266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #203
----
commit 54d31c5444df622090ba484eee6c562d1c3630d9
Author: rlei <rl...@pivotal.io>
Date: 2015-12-20T14:12:37Z
HAWQ-266. Check if krb_server_keyfile exist in hawq-site.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-266. Check if krb_server_keyfile...
Posted by ljainpivotalio <gi...@git.apache.org>.
Github user ljainpivotalio commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/203#discussion_r48192753
--- Diff: tools/bin/hawq_ctl ---
@@ -111,10 +111,13 @@ class HawqInit:
self.standby_host_name = ''
if 'enable_secure_filesystem' in self.hawq_dict:
- self.enable_secure_filesystem=self.hawq_dict['enable_secure_filesystem']
- self.krb_server_keyfile =self.hawq_dict['krb_server_keyfile']
+ self.enable_secure_filesystem = self.hawq_dict['enable_secure_filesystem']
--- End diff --
**enable_secure_filesystem** could be set to **OFF** in hawq-site.xml. Current logic is assuming that security is on as long as enable_secure_filesystem parameter is present.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-266. Check if krb_server_keyfile...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/203#issuecomment-166204732
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-266. Check if krb_server_keyfile...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/203#issuecomment-166205179
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-266. Check if krb_server_keyfile...
Posted by ljainpivotalio <gi...@git.apache.org>.
Github user ljainpivotalio commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/203#discussion_r48287388
--- Diff: tools/bin/hawq_ctl ---
@@ -111,10 +111,13 @@ class HawqInit:
self.standby_host_name = ''
if 'enable_secure_filesystem' in self.hawq_dict:
- self.enable_secure_filesystem=self.hawq_dict['enable_secure_filesystem']
- self.krb_server_keyfile =self.hawq_dict['krb_server_keyfile']
+ self.enable_secure_filesystem = self.hawq_dict['enable_secure_filesystem']
--- End diff --
Thanks for the clarification.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-266. Check if krb_server_keyfile...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/203#discussion_r48213485
--- Diff: tools/bin/hawq_ctl ---
@@ -111,10 +111,13 @@ class HawqInit:
self.standby_host_name = ''
if 'enable_secure_filesystem' in self.hawq_dict:
- self.enable_secure_filesystem=self.hawq_dict['enable_secure_filesystem']
- self.krb_server_keyfile =self.hawq_dict['krb_server_keyfile']
+ self.enable_secure_filesystem = self.hawq_dict['enable_secure_filesystem']
--- End diff --
Current logic is if 'enable_secure_filesystem' present in hawq-site.xml, then get it's value, the value depend on what user set it. If it does not present, we assume it's off.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-266. Check if krb_server_keyfile...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave closed the pull request at:
https://github.com/apache/incubator-hawq/pull/203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---