[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #1999: [WIP] HIVE-24803: update metrics and allocation after kill trigger status becomes available

[GitBox <gi...@apache.org>]

ashish-kumar-sharma commented on a change in pull request #1999:
URL: https://github.com/apache/hive/pull/1999#discussion_r583359309



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
##########
@@ -744,6 +748,19 @@ private void processCurrentEvents(EventState e, WmThreadSyncWork syncWork) throw
     }
   }
 
+  private void updatePoolMetricsAfterKillTrigger(HashSet<String> poolsToRedistribute, KillQueryContext ctx) {
+    String poolName = ctx.getPoolName();
+    if (poolName != null) {

Review comment:
       use StringUtils.isEmpty(poolName)

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
##########
@@ -2225,13 +2251,17 @@ private void resetAndQueueKill(Map<WmTezSession, KillQueryContext> toKillQuery,
     KillQueryContext killQueryContext, Map<WmTezSession, GetRequest> toReuse) {
 
     WmTezSession toKill = killQueryContext.session;
+    String poolName = toKill.getPoolName();
+    boolean validPoolName = poolName != null;

Review comment:
       break this line into 2. so that code will be more readable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org