You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by hongbin ma <ma...@apache.org> on 2015/08/20 16:33:41 UTC
eclipse formatter messing up apache license header
hi,
I'm using Eclipse Java EE IDE for Web Developers, Version: Kepler Service
Release 2 on mac.
I imported the dev-support/hbase-eclipse-formatter.xml as
http://hbase.apache.org/book.html#eclipse.code.formatting.
When I format the code, everything is formatted as expected except:
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
is formatted to:
/**
* Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
* agreements. See the NOTICE file distributed with this work for
additional information regarding
* copyright ownership. The ASF licenses this file to you under the Apache
License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the
License. You may obtain a
* copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless
required by applicable
* law or agreed to in writing, software distributed under the License is
distributed on an "AS IS"
* BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied. See the License
* for the specific language governing permissions and limitations under
the License.
*/
I'm wondering if anyone has the same problem with me.
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: eclipse formatter messing up apache license header
Posted by hongbin ma <ma...@apache.org>.
@Julian, Still the same problem.
@liyang sorry I sent to Kylin's dev mail thread by mistake.. I'll send it
to Hbase's dev list again
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: eclipse formatter messing up apache license header
Posted by Li Yang <li...@apache.org>.
This should go hbase dev list...
On Thu, Aug 20, 2015 at 11:24 PM, Julian Hyde <ju...@gmail.com> wrote:
> If you change the javadoc comment "/**" to a regular comment "/*", does
> eclipse still re-format the header?
>
> Julian
>
> > On Aug 20, 2015, at 07:33, hongbin ma <ma...@apache.org> wrote:
> >
> > hi,
> >
> > I'm using Eclipse Java EE IDE for Web Developers, Version: Kepler Service
> > Release 2 on mac.
> > I imported the dev-support/hbase-eclipse-formatter.xml as
> > http://hbase.apache.org/book.html#eclipse.code.formatting.
> >
> > When I format the code, everything is formatted as expected except:
> >
> > /**
> > * Licensed to the Apache Software Foundation (ASF) under one
> > * or more contributor license agreements. See the NOTICE file
> > * distributed with this work for additional information
> > * regarding copyright ownership. The ASF licenses this file
> > * to you under the Apache License, Version 2.0 (the
> > * "License"); you may not use this file except in compliance
> > * with the License. You may obtain a copy of the License at
> > *
> > * http://www.apache.org/licenses/LICENSE-2.0
> > *
> > * Unless required by applicable law or agreed to in writing, software
> > * distributed under the License is distributed on an "AS IS" BASIS,
> > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> > * See the License for the specific language governing permissions and
> > * limitations under the License.
> > */
> >
> > is formatted to:
> >
> > /**
> > * Licensed to the Apache Software Foundation (ASF) under one or more
> > contributor license
> > * agreements. See the NOTICE file distributed with this work for
> > additional information regarding
> > * copyright ownership. The ASF licenses this file to you under the Apache
> > License, Version 2.0 (the
> > * "License"); you may not use this file except in compliance with the
> > License. You may obtain a
> > * copy of the License at http://www.apache.org/licenses/LICENSE-2.0
> Unless
> > required by applicable
> > * law or agreed to in writing, software distributed under the License is
> > distributed on an "AS IS"
> > * BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > implied. See the License
> > * for the specific language governing permissions and limitations under
> > the License.
> > */
> >
> > I'm wondering if anyone has the same problem with me.
> >
> > --
> > Regards,
> >
> > *Bin Mahone | 马洪宾*
> > Apache Kylin: http://kylin.io
> > Github: https://github.com/binmahone
>
Re: eclipse formatter messing up apache license header
Posted by Julian Hyde <ju...@gmail.com>.
If you change the javadoc comment "/**" to a regular comment "/*", does eclipse still re-format the header?
Julian
> On Aug 20, 2015, at 07:33, hongbin ma <ma...@apache.org> wrote:
>
> hi,
>
> I'm using Eclipse Java EE IDE for Web Developers, Version: Kepler Service
> Release 2 on mac.
> I imported the dev-support/hbase-eclipse-formatter.xml as
> http://hbase.apache.org/book.html#eclipse.code.formatting.
>
> When I format the code, everything is formatted as expected except:
>
> /**
> * Licensed to the Apache Software Foundation (ASF) under one
> * or more contributor license agreements. See the NOTICE file
> * distributed with this work for additional information
> * regarding copyright ownership. The ASF licenses this file
> * to you under the Apache License, Version 2.0 (the
> * "License"); you may not use this file except in compliance
> * with the License. You may obtain a copy of the License at
> *
> * http://www.apache.org/licenses/LICENSE-2.0
> *
> * Unless required by applicable law or agreed to in writing, software
> * distributed under the License is distributed on an "AS IS" BASIS,
> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> * See the License for the specific language governing permissions and
> * limitations under the License.
> */
>
> is formatted to:
>
> /**
> * Licensed to the Apache Software Foundation (ASF) under one or more
> contributor license
> * agreements. See the NOTICE file distributed with this work for
> additional information regarding
> * copyright ownership. The ASF licenses this file to you under the Apache
> License, Version 2.0 (the
> * "License"); you may not use this file except in compliance with the
> License. You may obtain a
> * copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless
> required by applicable
> * law or agreed to in writing, software distributed under the License is
> distributed on an "AS IS"
> * BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied. See the License
> * for the specific language governing permissions and limitations under
> the License.
> */
>
> I'm wondering if anyone has the same problem with me.
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone