You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2020/06/09 04:04:53 UTC
[impala] 02/02: IMPALA-9830: Fix flakiness in test_mt_dop_scan_node
This is an automated email from the ASF dual-hosted git repository.
tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit dbd454445165829541c9e2c67cce5446bb535f46
Author: Bikramjeet Vig <bi...@gmail.com>
AuthorDate: Sun Jun 7 15:57:25 2020 -0700
IMPALA-9830: Fix flakiness in test_mt_dop_scan_node
This test has inherent flakiness due to it relying on instances
fetching scan ranges from a shared queue. The time sensitivity
enhanced the flakiness on a release build. So this change decreases
the mt_dop level to 8 which results in a failure rate of 0.05%.
This along with increasing the num of tries should make sure flakiness
is removed.
Change-Id: Ibc2f073096b9294205d2a18bd9cc44907b3f4da0
Reviewed-on: http://gerrit.cloudera.org:8080/16047
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
tests/query_test/test_mt_dop.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/query_test/test_mt_dop.py b/tests/query_test/test_mt_dop.py
index 382fc8a..8af3fa8 100644
--- a/tests/query_test/test_mt_dop.py
+++ b/tests/query_test/test_mt_dop.py
@@ -118,12 +118,13 @@ class TestMtDopScanNode(ImpalaTestSuite):
fq_table_name = "%s.store_sales_subset" % unique_database
self.execute_query("create table %s as select distinct(ss_sold_date_sk) as "
"sold_date from tpcds.store_sales limit 50" % fq_table_name)
- vector.get_value('exec_option')['mt_dop'] = 10
+ vector.get_value('exec_option')['mt_dop'] = 8
vector.get_value('exec_option')['runtime_filter_wait_time_ms'] = 100000
# Since this depends on instances fetching scan ranges from a shared queue, running
- # it multiple times ensures any flakiness is removed.
- NUM_TRIES = 10
+ # it multiple times ensures any flakiness is removed. On a release build it has a
+ # 0.05% failure rate.
+ NUM_TRIES = 100
failed_count = 0
for i in xrange(NUM_TRIES):
try: