You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/08/26 15:00:00 UTC
[I] refactor(cli): ship one Eval runtime in the npm CLI package [maka]
Astro-Han opened a new issue, #3933:
URL: https://github.com/apache/maka/issues/3933
## Problem
`copyEvalMirror()` in `scripts/release-cli-package.mjs:482` copies the whole staged `node_modules/@maka/eval` tree to `packages/eval` inside the published CLI package, so every install carries the Eval runtime twice.
The mirror is not pure redundancy: experiment configurations reference container paths under it, for example `/opt/maka-agent/packages/eval/dist/harbor-external-subject.js` in `packages/eval/experiments/terminal-bench-2.1-deepseek-v4-flash-eight-arm.json`. Those entries are what keeps the second copy alive.
## Desired outcome
Ship one Eval runtime. Keep `node_modules/@maka/eval` as the runtime and reduce the mirror to only the container entry points the experiment configurations actually resolve, instead of the entire tree.
Keep: standalone packaging, Eval behavior, and the container paths those experiments depend on. `maka eval` remains the only public Eval CLI.
The PR should list the exact entry points it keeps and show that no experiment configuration resolves a mirrored path outside that list.
## Alternatives or workarounds
Keeping the full mirror keeps install size and, worse, two runtimes that can diverge between releases.
Proposed in [#3618](https://github.com/apache/maka/discussions/3618). The rule for this issue is one end-to-end deletion, one PR, and strictly fewer maintained concepts; moving the same idea behind a new facade or compatibility bridge does not count.
Claude verified the consumer claims below against current `main`. A human contributor must confirm them and own the resulting change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] refactor(cli): ship one Eval runtime in the npm CLI package [maka]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #3933:
URL: https://github.com/apache/maka/issues/3933#issuecomment-5427358642
I'd like to take this one. I'll confirm the consumer claims against current `main`, then scope the mirror in `copyEvalMirror()` down to only the container entry points the experiment configurations actually resolve, and demonstrate in the PR that no experiment config resolves a mirrored path outside that kept list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] refactor(cli): ship one Eval runtime in the npm CLI package [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #3933: refactor(cli): ship one Eval runtime in the npm CLI package
URL: https://github.com/apache/maka/issues/3933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org