You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2020/12/08 05:45:42 UTC
[GitHub] [lucenenet] denisisack opened a new pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
denisisack opened a new pull request #381:
URL: https://github.com/apache/lucenenet/pull/381
Transform use of IList to BlockingCollection as it's more viable in concurrent scenario as simply doesn't require to have create a new copy so as error related to use of List as it's internal structure change. BlockingCollection allow many features suitable for such concurrent scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] denisisack closed pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
denisisack closed pull request #381:
URL: https://github.com/apache/lucenenet/pull/381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] denisisack commented on pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
denisisack commented on pull request #381:
URL: https://github.com/apache/lucenenet/pull/381#issuecomment-719284622
I have tried understanding somehow might be because of my computing resource but after improving UpdateMergeThreads results at least deterministic as per my limited Computing resource was some convinced it had better result but being limited does provide me less clarity check you may suggest other way or just close PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] denisisack commented on pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
denisisack commented on pull request #381:
URL: https://github.com/apache/lucenenet/pull/381#issuecomment-719302002
Some test are skipped because of low computing resources but if it doesn't help then you can just close as it of more practical advantage to get big picture, will try checking error remaining to see options presents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] denisisack closed pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
denisisack closed pull request #381:
URL: https://github.com/apache/lucenenet/pull/381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on pull request #381:
URL: https://github.com/apache/lucenenet/pull/381#issuecomment-774396111
Thanks for the attempt. However, this didn't meet the expectation of a high-performance merge scheduler that we were looking for.
That said, you did identify a previously unknown issue with `DocTermOrds.OrdWrappedTermsEnum` (#405) that helped to move us a step in the right direction, and for that we thank you for your contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on pull request #381:
URL: https://github.com/apache/lucenenet/pull/381#issuecomment-716488461
Thanks for the PR.
Unfortunately, this causes the performance of `TaskMergeScheduler` to become unacceptably slow.
## Without Change
## With Change
Blocking would seem to defeat the purpose of a concurrent merge scheduler. However, if you would like to take another stab at it, I will leave this PR open. See #354 for a description of what we are looking for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 closed pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
NightOwl888 closed pull request #381:
URL: https://github.com/apache/lucenenet/pull/381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] denisisack edited a comment on pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
denisisack edited a comment on pull request #381:
URL: https://github.com/apache/lucenenet/pull/381#issuecomment-719302002
Some test are skipped because of low computing resources but if it doesn't help then you can just close , will try checking error remaining to see options presents.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] denisisack commented on pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
denisisack commented on pull request #381:
URL: https://github.com/apache/lucenenet/pull/381#issuecomment-719291415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] denisisack closed pull request #381: TaskMergeScheduler error on use _mergethreads Tracking Master
Posted by GitBox <gi...@apache.org>.
denisisack closed pull request #381:
URL: https://github.com/apache/lucenenet/pull/381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org