[GitHub] [activemq-artemis] wy96f opened a new pull request #2740: ARTEMIS-2414 Sync before closing file in case data loss

[GitBox <gi...@apache.org>]

wy96f opened a new pull request #2740: ARTEMIS-2414 Sync before closing file in case data loss
URL: https://github.com/apache/activemq-artemis/pull/2740
 
 
   When we open a new page, the page sync timer might sync the new page, i.e. the new page and after it responses are sent back to client. For the old page is closed(not synced), we may lose messages if server crashes before dirty page cache written back into disk.
   
   When we switch journal file to the new file, TimedBuffer::flushBatch will be called in the old file. Then the file would be synced except in the case user sets "journalDatasync" to false. For safety we'd better sync journal file before closing it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services