You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by xi...@apache.org on 2023/02/09 03:14:27 UTC
[incubator-uniffle] branch master updated: [#525][FOLLOWUP] add omitempty tag (#565)
This is an automated email from the ASF dual-hosted git repository.
xianjin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new 07799466 [#525][FOLLOWUP] add omitempty tag (#565)
07799466 is described below
commit 077994666c36d815070c25ba0aabcd4437eb4405
Author: advancedxy <xi...@apache.org>
AuthorDate: Thu Feb 9 11:14:22 2023 +0800
[#525][FOLLOWUP] add omitempty tag (#565)
### What changes were proposed in this pull request?
Add omitempty for `RPCNodePort` and `HTTPNodePort`
### Why are the changes needed?
This is a bug fixes. Otherwise, rss spec cannot omit `rpcNodePort` and `httpNodePort`
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No need
---
.../operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go b/deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go
index adf8aab8..5c1947e3 100644
--- a/deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go
+++ b/deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go
@@ -97,11 +97,11 @@ type CoordinatorConfig struct {
// RPCNodePort defines rpc port of node port service used for coordinators' external access.
// +optional
- RPCNodePort []int32 `json:"rpcNodePort"`
+ RPCNodePort []int32 `json:"rpcNodePort,omitempty"`
// HTTPNodePort defines http port of node port service used for coordinators' external access.
// +optional
- HTTPNodePort []int32 `json:"httpNodePort"`
+ HTTPNodePort []int32 `json:"httpNodePort,omitempty"`
}
// ShuffleServerConfig records configuration used to generate workload of shuffle servers.