You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Andrew Stevens (JIRA)" <ji...@apache.org> on 2006/07/28 12:17:15 UTC

[jira] Created: (COCOON-1887) Host selector should be case insensitive

Host selector should be case insensitive
----------------------------------------

                 Key: COCOON-1887
                 URL: http://issues.apache.org/jira/browse/COCOON-1887
             Project: Cocoon
          Issue Type: Bug
          Components: - Components: Sitemap
    Affects Versions: 2.1.8
            Reporter: Andrew Stevens
            Priority: Minor


According to the relevant RFC (RFC3986 section 3.2.2) the host part of a HTTP URL should be case insensitive; the remaining path is case sensitive, but scheme and host should not be.  However, the host selector is currently not case insensitive (since NamedPatternsSelector.checkPatterns(String, String) uses indexOf) and therefore if the requested URL uses a different case for the host part the pipeline may choose the wrong case in the map:select.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (COCOON-1887) Host selector should be case insensitive

Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jörg Heinicke closed COCOON-1887.
---------------------------------

    Resolution: Fixed

Patch applied to 2.1 and 2.2.

> Host selector should be case insensitive
> ----------------------------------------
>
>                 Key: COCOON-1887
>                 URL: https://issues.apache.org/jira/browse/COCOON-1887
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Components: Sitemap
>    Affects Versions: 2.1.8, 2.1.11, 2.2
>            Reporter: Andrew Stevens
>            Assignee: Jörg Heinicke
>            Priority: Minor
>             Fix For: 2.1.12-dev (Current SVN), 2.2-dev (Current SVN)
>
>         Attachments: HostSelectorPatch.diff
>
>
> According to the relevant RFC (RFC3986 section 3.2.2) the host part of a HTTP URL should be case insensitive; the remaining path is case sensitive, but scheme and host should not be.  However, the host selector is currently not case insensitive (since NamedPatternsSelector.checkPatterns(String, String) uses indexOf) and therefore if the requested URL uses a different case for the host part the pipeline may choose the wrong case in the map:select.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-1887) Host selector should be case insensitive

Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jörg Heinicke updated COCOON-1887:
----------------------------------

                  Fix Version/s: 2.2-dev (Current SVN)
                                 2.1.12-dev (Current SVN)
    Affects version (Component): Parent values: Components: Sitemap(10152). Level 1 values: 1.0.0(10381). 
        Fix version (Component): Parent values: Components: Sitemap(10229). 
                       Assignee: Jörg Heinicke
              Affects Version/s: 2.2
                                 2.1.11

> Host selector should be case insensitive
> ----------------------------------------
>
>                 Key: COCOON-1887
>                 URL: https://issues.apache.org/jira/browse/COCOON-1887
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Components: Sitemap
>    Affects Versions: 2.1.8, 2.1.11, 2.2
>            Reporter: Andrew Stevens
>            Assignee: Jörg Heinicke
>            Priority: Minor
>             Fix For: 2.1.12-dev (Current SVN), 2.2-dev (Current SVN)
>
>         Attachments: HostSelectorPatch.diff
>
>
> According to the relevant RFC (RFC3986 section 3.2.2) the host part of a HTTP URL should be case insensitive; the remaining path is case sensitive, but scheme and host should not be.  However, the host selector is currently not case insensitive (since NamedPatternsSelector.checkPatterns(String, String) uses indexOf) and therefore if the requested URL uses a different case for the host part the pipeline may choose the wrong case in the map:select.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COCOON-1887) Host selector should be case insensitive

Posted by "Andrew Stevens (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1887?page=all ]

Andrew Stevens updated COCOON-1887:
-----------------------------------

    Attachment: HostSelectorPatch.diff

Patch against 2.1.x branch that adds a unit test for hostname & value being of different cases, and fixes the host selector so that the test passes.  The existing behaviour is preserved for any other NamedPatternsSelector subclasses, since they may need to be case-sensitive.

> Host selector should be case insensitive
> ----------------------------------------
>
>                 Key: COCOON-1887
>                 URL: http://issues.apache.org/jira/browse/COCOON-1887
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Components: Sitemap
>    Affects Versions: 2.1.8
>            Reporter: Andrew Stevens
>            Priority: Minor
>         Attachments: HostSelectorPatch.diff
>
>
> According to the relevant RFC (RFC3986 section 3.2.2) the host part of a HTTP URL should be case insensitive; the remaining path is case sensitive, but scheme and host should not be.  However, the host selector is currently not case insensitive (since NamedPatternsSelector.checkPatterns(String, String) uses indexOf) and therefore if the requested URL uses a different case for the host part the pipeline may choose the wrong case in the map:select.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (COCOON-1887) Host selector should be case insensitive

Posted by "Andrew Stevens (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/COCOON-1887?page=all ]

Andrew Stevens updated COCOON-1887:
-----------------------------------

    Other Info: [Patch available]

> Host selector should be case insensitive
> ----------------------------------------
>
>                 Key: COCOON-1887
>                 URL: http://issues.apache.org/jira/browse/COCOON-1887
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Components: Sitemap
>    Affects Versions: 2.1.8
>            Reporter: Andrew Stevens
>            Priority: Minor
>         Attachments: HostSelectorPatch.diff
>
>
> According to the relevant RFC (RFC3986 section 3.2.2) the host part of a HTTP URL should be case insensitive; the remaining path is case sensitive, but scheme and host should not be.  However, the host selector is currently not case insensitive (since NamedPatternsSelector.checkPatterns(String, String) uses indexOf) and therefore if the requested URL uses a different case for the host part the pipeline may choose the wrong case in the map:select.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira