[GitHub] [guacamole-client] necouchman commented on a change in pull request #303: GUACAMOLE-579: Get user attributes from CAS ticket

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #303: GUACAMOLE-579: Get user attributes from CAS ticket
URL: https://github.com/apache/guacamole-client/pull/303#discussion_r296061455
 
 

 ##########
 File path: guacamole-ext/src/main/java/org/apache/guacamole/token/TokenName.java
 ##########
 @@ -63,35 +57,38 @@
     /**
      * This utility class should not be instantiated.
      */
-    private TokenName() {}
+    protected TokenName() {}
 
     /**
      * Generates the name of the parameter token that should be populated with
-     * the value of the given LDAP attribute. The name of the LDAP attribute
-     * will automatically be transformed from "CamelCase", "headlessCamelCase",
+     * the value of the given attribute. The name of the attribute will
+     * automatically be transformed from "CamelCase", "headlessCamelCase",
      * "lowercase_with_underscores", and "mixes_ofBoth_Styles" to consistent
      * "UPPERCASE_WITH_UNDERSCORES". Each returned attribute will be prefixed
      * with "LDAP_".
      *
      * @param name
-     *     The name of the LDAP attribute to use to generate the token name.
+     *     The name of the attribute to use to generate the token name.
+     * 
+     * @param prefix
+     *     The prefix to prepend to the generated token name.
      *
      * @return
      *     The name of the parameter token that should be populated with the
-     *     value of the LDAP attribute having the given name.
+     *     value of the attribute having the given name.
      */
-    public static String fromAttribute(String name) {
+    public static String fromAttribute(final String name, final String prefix) {
 
 Review comment:
   Implemented.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services