You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Henning P. Schmiedehausen" <hp...@intermeta.de> on 2005/09/13 23:04:28 UTC
Discussion: Change torque JDBCTransformTask to not use xerces
This is a proposal for a post-rc2, pre-rc3 change!
I've seen that Thomas is ramping up the rc2 release and I don't want
to interfere with this (and his well-deserved vacation :-) ).
However, I'd like to give Thomas a chance to throw in a word or two
before he leaves. :-)
If you compile the torque-generator from the trunk using JDK 1.4 and
comment out the JDK 1.4 included xerces and xml-api dependencies, you
will notice that the generator no longer compiles.
The reason for this is the JDBCTransformTask which uses the
org.apache.xerces.dom.DocumentImpl and a number of other, internal
classes directly (though DocumentImpl e.g. contains the notice "Usage
of this class is not supported. It may be altered or removed at any
time." (see http://xml.apache.org/xerces2-j/javadocs/xerces2/org/apache/xerces/dom/DocumentImpl.html))
When using JDK 1.3, this does hurt only a little bit; because this JDK
release does not contain javax.xml or org.w3c.dom packages, you will
have to include xerces and xml-apis anyway.
But on JDK 1.4, you get about a Megabyte of dependencies that are
actually not used at all except for this lone task. Which is not even
a correct use case. :-)
I therefore would like to rewrite the current JDBCTransformTask using
some other XML writing library. jdom (150k) or dom4j (300k) come to
mind. It shouldn't be too hard and putting some unit tests on top will
help here.
Opinions?
Best regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training, Development
4 - 8 - 15 - 16 - 23 - 42
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
Re: Discussion: Change torque JDBCTransformTask to not use xerces
Posted by Thomas Fischer <fi...@seitenbau.net>.
Hi,
I have the following remarks
- xerces is apache software, jdom and dom4j are not. Does the apache
policy allows including non-apache libraries in distributions (I would
guess yes, but I am not sure). If not, I'd suggest we stick with xerces.
- I have had the slight hope that 3.2-rc2 could be retagged into 3.2 after
trying it out and nobody finding any bugs at all :-). How keen are you to
get this into 3.2 ? (Of course, if we need a rc3, it'll go in anyway)
- I use jdom quite a lot and think it is very good stuff. It is a bit
peculiar about the treatment of the \r part in windows line endings.
Never used dom4j, no idea about it.
- As we have already decided to not support jdk 1.3 out of the box in the
generator, I agree that xerces and xml-apis then could be left out of the
dependencies.
If you think this is worth while your time, go ahead.
Thomas
"Henning P. Schmiedehausen" <hp...@intermeta.de> schrieb am 13.09.2005
23:04:28:
> This is a proposal for a post-rc2, pre-rc3 change!
>
> I've seen that Thomas is ramping up the rc2 release and I don't want
> to interfere with this (and his well-deserved vacation :-) ).
>
> However, I'd like to give Thomas a chance to throw in a word or two
> before he leaves. :-)
>
> If you compile the torque-generator from the trunk using JDK 1.4 and
> comment out the JDK 1.4 included xerces and xml-api dependencies, you
> will notice that the generator no longer compiles.
>
> The reason for this is the JDBCTransformTask which uses the
> org.apache.xerces.dom.DocumentImpl and a number of other, internal
> classes directly (though DocumentImpl e.g. contains the notice "Usage
> of this class is not supported. It may be altered or removed at any
> time." (see http://xml.apache.org/xerces2-
> j/javadocs/xerces2/org/apache/xerces/dom/DocumentImpl.html))
>
> When using JDK 1.3, this does hurt only a little bit; because this JDK
> release does not contain javax.xml or org.w3c.dom packages, you will
> have to include xerces and xml-apis anyway.
>
> But on JDK 1.4, you get about a Megabyte of dependencies that are
> actually not used at all except for this lone task. Which is not even
> a correct use case. :-)
>
> I therefore would like to rewrite the current JDBCTransformTask using
> some other XML writing library. jdom (150k) or dom4j (300k) come to
> mind. It shouldn't be too hard and putting some unit tests on top will
> help here.
>
> Opinions?
>
> Best regards
> Henning
>
>
>
>
> --
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
> hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
>
> RedHat Certified Engineer -- Jakarta Turbine Development -- hero for
hire
> Linux, Java, perl, Solaris -- Consulting, Training, Development
>
> 4 - 8 - 15 - 16 - 23 - 42
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: torque-dev-help@db.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org