[jira] [Work logged] (AMQ-8009) Spring upgrade required for Karaf feature

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-8009?focusedWorklogId=469065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469065 ]

ASF GitHub Bot logged work on AMQ-8009:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Aug/20 07:30
            Start Date: 11/Aug/20 07:30
    Worklog Time Spent: 10m 
      Work Description: jbonofre commented on a change in pull request #552:
URL: https://github.com/apache/activemq/pull/552#discussion_r468381208



##########
File path: activemq-karaf/src/main/resources/features-core.xml
##########
@@ -25,7 +25,7 @@
 
     <!-- Bundles needed if only client will be deployed in the container -->
     <feature name="activemq-client" description="ActiveMQ client libraries" version="${project.version}" resolver="(obr)" start-level="50">
-        <feature version="[4,5)">spring</feature>
+        <feature version="[4,6)">spring</feature>

Review comment:
       This is not required and actually dangerous as ActiveMQ only supports Spring 4.x for now.
   The only requirement in Karaf is to have `spring-legacy` features repo but it's already OK.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 469065)
    Time Spent: 20m  (was: 10m)

> Spring upgrade required for Karaf feature
> -----------------------------------------
>
>                 Key: AMQ-8009
>                 URL: https://issues.apache.org/jira/browse/AMQ-8009
>             Project: ActiveMQ
>          Issue Type: Task
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>            Priority: Major
>             Fix For: 5.17.0, 5.16.1, 5.15.14
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently deploying activemq-client in Karaf with Spring 5 fails with:
> osgi.identity; osgi.identity=activemq-client; type=karaf.feature; version="[5.16.0,5.16.0]"; filter:="(&(osgi.identity=activemq-client)(type=karaf.feature)(version>=5.16.0)(version<=5.16.0))" [caused by: Unable to resolve activemq-client/5.16.0: missing requirement [activemq-client/5.16.0] osgi.identity; osgi.identity=spring; type=karaf.feature; version="[4.0.0,5.0.0)"]
> We need to allow Spring 5 here in the feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)