You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2011/01/04 23:38:00 UTC
svn commit: r1055221 - in
/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd:
CpdReportTest.java PmdReportTest.java
Author: hboutemy
Date: Tue Jan 4 22:38:00 2011
New Revision: 1055221
URL: http://svn.apache.org/viewvc?rev=1055221&view=rev
Log:
use StringBuffer instead of String+= in loops
Modified:
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java
maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java?rev=1055221&r1=1055220&r2=1055221&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/CpdReportTest.java Tue Jan 4 22:38:00 2011
@@ -171,16 +171,18 @@ public class CpdReportTest
private String readFile( File file )
throws IOException
{
- String str = "", strTmp = "";
+ String strTmp;
+ StringBuffer str = new StringBuffer( (int)file.length() );
BufferedReader in = new BufferedReader( new FileReader( file ) );
while ( ( strTmp = in.readLine() ) != null )
{
- str = str + " " + strTmp;
+ str.append( ' ' );
+ str.append( strTmp );
}
in.close();
- return str;
+ return str.toString();
}
public void testWriteNonHtml()
Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java?rev=1055221&r1=1055220&r2=1055221&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java Tue Jan 4 22:38:00 2011
@@ -241,22 +241,18 @@ public class PmdReportTest
private String readFile( File file )
throws IOException
{
- String str = "", strTmp = "";
-
+ String strTmp;
+ StringBuffer str = new StringBuffer( (int)file.length() );
BufferedReader in = new BufferedReader( new FileReader( file ) );
- try
- {
- while ( ( strTmp = in.readLine() ) != null )
- {
- str += " " + strTmp;
- }
- }
- finally
+
+ while ( ( strTmp = in.readLine() ) != null )
{
- in.close();
+ str.append( ' ' );
+ str.append( strTmp );
}
+ in.close();
- return str;
+ return str.toString();
}