You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/08/09 21:43:11 UTC
Review Request 71265: Added a test to ensure that filters are cleared
upon unsuppression.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71265/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Bugs: MESOS-9932
https://issues.apache.org/jira/browse/MESOS-9932
Repository: mesos
Description
-------
Added a test to ensure that filters are cleared upon unsuppression.
Diffs
-----
src/tests/master/update_framework_tests.cpp 79aac41d618a6a27864162fefff79109b9c3c5f1
Diff: https://reviews.apache.org/r/71265/diff/1/
Testing
-------
Ran in repetition.
Ensured this test fails on master branch.
Thanks,
Benjamin Mahler
Re: Review Request 71265: Added a test to ensure that filters are
cleared upon unsuppression.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71265/#review217147
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71264, 71265]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 9, 2019, 9:43 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71265/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2019, 9:43 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-9932
> https://issues.apache.org/jira/browse/MESOS-9932
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to ensure that filters are cleared upon unsuppression.
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 79aac41d618a6a27864162fefff79109b9c3c5f1
>
>
> Diff: https://reviews.apache.org/r/71265/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition.
> Ensured this test fails on master branch.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 71265: Added a test to ensure that filters are
cleared upon unsuppression.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71265/#review217158
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On Aug. 9, 2019, 2:43 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71265/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2019, 2:43 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-9932
> https://issues.apache.org/jira/browse/MESOS-9932
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to ensure that filters are cleared upon unsuppression.
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp 79aac41d618a6a27864162fefff79109b9c3c5f1
>
>
> Diff: https://reviews.apache.org/r/71265/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition.
> Ensured this test fails on master branch.
>
>
> Thanks,
>
> Benjamin Mahler
>
>