[GitHub] [rocketmq] xiangwangcheng commented on issue #1657: [ISSUE #1588] Fix 1588 retry doesn't work when sending msg in async mode and the broker is down

[GitBox <gi...@apache.org>]

xiangwangcheng commented on issue #1657: [ISSUE #1588] Fix 1588  retry doesn't work when sending msg in async mode and the broker is down
URL: https://github.com/apache/rocketmq/pull/1657#issuecomment-566866051
 
 
   This solution can not cover the situation when sending message timeout  before the `sendMessageAsync` is invoked.
   As I mentioned in the issue,  reuse the loop retry logic would be simpler and clearer.
   
   ![image](https://user-images.githubusercontent.com/8049014/71053954-30bbb480-218b-11ea-9f31-cad9d0e74673.png)
   
   This make us have two seperated retry logic, one is in charge of resending messages when failed in the sending phrase, the other is in charge of resending when failed in the response-process phrase.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services