You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/04 12:21:06 UTC

[GitHub] [mynewt-mcumgr] sjanc opened a new pull request #67: Add rat-excludes and missing licence headers

sjanc opened a new pull request #67: Add rat-excludes and missing licence headers
URL: https://github.com/apache/mynewt-mcumgr/pull/67
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] sjanc commented on a change in pull request #67: Add rat-excludes and missing licence headers

Posted by GitBox <gi...@apache.org>.

sjanc commented on a change in pull request #67: Add rat-excludes and missing licence headers
URL: https://github.com/apache/mynewt-mcumgr/pull/67#discussion_r388214842

##########
File path: samples/smp_svr/zephyr/src/main.c
##########
@@ -1,3 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+

Review comment:
The licence is the same and I left original copyright. It is just that this was initially copied from zephyr which doesn't use explicit licence header but only SPDX identifier.

I'm open for suggestion. Removing SPDX and leaving only copyright notice is also an option. Or maybe put all under same comment /* */ block..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] utzig commented on a change in pull request #67: Add rat-excludes and missing licence headers

Posted by GitBox <gi...@apache.org>.

utzig commented on a change in pull request #67: Add rat-excludes and missing licence headers
URL: https://github.com/apache/mynewt-mcumgr/pull/67#discussion_r388198556
 
 

 ##########
 File path: samples/smp_svr/zephyr/src/main.c
 ##########
 @@ -1,3 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
 
 Review comment:
   Is it OK to add a new license **over** an existing license?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] sjanc merged pull request #67: Add rat-excludes and missing licence headers

Posted by GitBox <gi...@apache.org>.

sjanc merged pull request #67: Add rat-excludes and missing licence headers
URL: https://github.com/apache/mynewt-mcumgr/pull/67
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] carlescufi commented on a change in pull request #67: Add rat-excludes and missing licence headers

Posted by GitBox <gi...@apache.org>.

carlescufi commented on a change in pull request #67: Add rat-excludes and missing licence headers
URL: https://github.com/apache/mynewt-mcumgr/pull/67#discussion_r388273165

Review comment:
The copyright is actually wrong anyway, Wind River did not contribute that `main.c`. So I would just get rid of everything below this line.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] sjanc commented on issue #67: Add rat-excludes and missing licence headers

Posted by GitBox <gi...@apache.org>.

sjanc commented on issue #67: Add rat-excludes and missing licence headers
URL: https://github.com/apache/mynewt-mcumgr/pull/67#issuecomment-594489463
 
 
   @nvlsianpu @carlescufi    FYI  some zephyr code has SPDX identifiers so I left those, although it is not used in ASF. Let me know if you are fine with this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-mcumgr] sjanc commented on a change in pull request #67: Add rat-excludes and missing licence headers

Posted by GitBox <gi...@apache.org>.

sjanc commented on a change in pull request #67: Add rat-excludes and missing licence headers
URL: https://github.com/apache/mynewt-mcumgr/pull/67#discussion_r388280426
 
 

 ##########
 File path: samples/smp_svr/zephyr/src/main.c
 ##########
 @@ -1,3 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
 
 Review comment:
   OK, I'll update PR 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services