[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9909: [multistage] fix function usage of casting

[GitBox <gi...@apache.org>]

siddharthteotia commented on code in PR #9909:
URL: https://github.com/apache/pinot/pull/9909#discussion_r1044762826


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/FilterOperator.java:
##########
@@ -46,14 +48,14 @@
 public class FilterOperator extends BaseOperator<TransferableBlock> {
   private static final String EXPLAIN_NAME = "FILTER";
   private final Operator<TransferableBlock> _upstreamOperator;
-  private final FilterOperand _filterOperand;
+  private final TransformOperand _filterOperand;

Review Comment:
   Not sure I follow this change. 
   
   This makes it look like that operand will be a function based evaluation which may not be necessarily true ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org