You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Lchangliang (via GitHub)" <gi...@apache.org> on 2023/03/13 02:34:16 UTC

[GitHub] [doris] Lchangliang opened a new pull request, #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Lchangliang opened a new pull request, #17710:
URL: https://github.com/apache/doris/pull/17710

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   We want to use file cache for caching cold data in S3. When reading them, we want to know where the data come from and the time taken to read the datas. So we support the metrics in olap scan node. And for clearing the information, i also update the fields about the metrics.
    
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Lchangliang commented on pull request #17710: [Improve](FileCahe) Support the file cache profile in olap scan node and Update the profile

Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1493741966

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Lchangliang commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1465996698

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1465616523

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Lchangliang commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1465583935

   run buildall
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zxealous commented on a diff in pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "zxealous (via GitHub)" <gi...@apache.org>.
zxealous commented on code in PR #17710:
URL: https://github.com/apache/doris/pull/17710#discussion_r1133406320


##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -528,6 +528,20 @@ void NewOlapScanner::_update_counters_before_close() {
                    stats.inverted_index_searcher_open_timer);
     COUNTER_UPDATE(olap_parent->_inverted_index_searcher_search_timer,
                    stats.inverted_index_searcher_search_timer);
+    
+    COUNTER_UPDATE(olap_parent->_num_local_io_total, stats.file_cache_stats.num_local_io_total);

Review Comment:
   FileCacheStatistics is not defined in OlapReaderStatistics?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17710: [Improve](FileCahe) Support the file cache profile in olap scan node and Update the profile

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1493731005

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Lchangliang commented on pull request #17710: [Improve](FileCahe) Support the file cache profile in olap scan node and Update the profile

Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1493726368

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1465453967

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Lchangliang commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1465452229

   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1465586163

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1466000801

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zxealous commented on a diff in pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "zxealous (via GitHub)" <gi...@apache.org>.
zxealous commented on code in PR #17710:
URL: https://github.com/apache/doris/pull/17710#discussion_r1133406320


##########
be/src/vec/exec/scan/new_olap_scanner.cpp:
##########
@@ -528,6 +528,20 @@ void NewOlapScanner::_update_counters_before_close() {
                    stats.inverted_index_searcher_open_timer);
     COUNTER_UPDATE(olap_parent->_inverted_index_searcher_search_timer,
                    stats.inverted_index_searcher_search_timer);
+    
+    COUNTER_UPDATE(olap_parent->_num_local_io_total, stats.file_cache_stats.num_local_io_total);

Review Comment:
   FileCacheStatistics is not defined in OlapReaderStatistics?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1467230555

   Please hold until this PR #17586 merged, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Lchangliang commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1465422011

   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Lchangliang commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1486646507

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1486653771

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17710: [Improve](FileCahe) Support the file cache profile iin olap scan node and Update the profile

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1465424265

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman merged pull request #17710: [Improve](FileCahe) Support the file cache profile in olap scan node and Update the profile

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #17710:
URL: https://github.com/apache/doris/pull/17710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17710: [Improve](FileCahe) Support the file cache profile in olap scan node and Update the profile

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1493749204

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] AshinGau commented on pull request #17710: [Improve](FileCahe) Support the file cache profile in olap scan node and Update the profile

Posted by "AshinGau (via GitHub)" <gi...@apache.org>.
AshinGau commented on PR #17710:
URL: https://github.com/apache/doris/pull/17710#issuecomment-1493733698

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org