You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/06 11:07:18 UTC

[GitHub] [incubator-dolphinscheduler] yangyichao-mango opened a new pull request #2915: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

yangyichao-mango opened a new pull request #2915:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2915


   ## What is the purpose of the pull request
   
   *Fix the mysql version and datetime sql syntax limited error for 5.5x - 5.64.*
   
   ## Brief change log
   
     - *Remove the CURRENT_TIMESTAMP in sql file.*
     - *Change the sql datetime(0) syntax to common syntax datetime, because mysql5.5x does not support the datetime(0) syntax, and datetime syntax is be in common use in mysql5.x and mysql8.x.*
     - *There is no need to set datetime in java code, because the default time was set up before.*
   
   ## Verify this pull request
   
   This pull request is code cleanup without any test coverage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] gabrywu edited a comment on pull request #2915: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

Posted by GitBox <gi...@apache.org>.
gabrywu edited a comment on pull request #2915:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2915#issuecomment-643619262


   @yangyichao-mango same issue https://github.com/apache/incubator-dolphinscheduler/pull/2914,   https://github.com/apache/incubator-dolphinscheduler/pull/2911
   I will close other issues


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #2915: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #2915:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2915


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] gabrywu commented on pull request #2915: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

Posted by GitBox <gi...@apache.org>.
gabrywu commented on pull request #2915:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2915#issuecomment-643619262


   @yangyichao-mango same issue https://github.com/apache/incubator-dolphinscheduler/pull/2914,https://github.com/apache/incubator-dolphinscheduler/pull/2911
   I will close other issues


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #2915: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

Posted by GitBox <gi...@apache.org>.
yangyichao-mango edited a comment on pull request #2915:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2915#issuecomment-643634097


   > @yangyichao-mango same issue https://github.com/apache/incubator-dolphinscheduler/pull/2914 
   > 
   > I will close it. which one should be closed? https://github.com/apache/incubator-dolphinscheduler/pull/2911 ,https://github.com/apache/incubator-dolphinscheduler/pull/2915
   
   Those PRs are not for the same version， because this issue involves three released versions, so I fix for three versions and commit three PRs for three different dev branches.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] gabrywu edited a comment on pull request #2915: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

Posted by GitBox <gi...@apache.org>.
gabrywu edited a comment on pull request #2915:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2915#issuecomment-643619262


   @yangyichao-mango same issue https://github.com/apache/incubator-dolphinscheduler/pull/2914 
   I will close it. which one should be closed? https://github.com/apache/incubator-dolphinscheduler/pull/2911 ,https://github.com/apache/incubator-dolphinscheduler/pull/2915


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #2915: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #2915:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2915#issuecomment-643634097


   > @yangyichao-mango same issue https://github.com/apache/incubator-dolphinscheduler/pull/2914 
   > 
   > I will close it. which one should be closed? https://github.com/apache/incubator-dolphinscheduler/pull/2911 ,https://github.com/apache/incubator-dolphinscheduler/pull/2915
   
   Those PR is not for the same version， because this issue involves three released versions, so I fix for three versions and commit three PRs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org