You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2010/11/01 16:45:17 UTC

Re: make check-ctypes-python fails when executed from non src build direction

Noorul Islam K M wrote on Mon, Nov 01, 2010 at 22:09:23 +0530:
> Julian Foad <ju...@wandisco.com> writes:
> > It looks like build_functions_py() expects to create functions.py in the
> > *source* directory, and build/run_ctypesgen.sh intentionally creates it
> > in the *build* directory.
> 
> I think setup.py is no longer used to generate bindings.
> 

subversion/bindings/ctypes-python/README still refers to setup.py.

Re: make check-ctypes-python fails when executed from non src build direction

Posted by Julian Foad <ju...@wandisco.com>.
On Mon, 2010-11-01 at 13:29 -0400, Greg Stein wrote:
> On Mon, Nov 1, 2010 at 13:22, Jeremy Whitlock <jc...@gmail.com> wrote:
> >...
> >>> subversion/bindings/ctypes-python/README still refers to setup.py.
> >>
> >> I think this is for those who are not using --with-ctypesgen option
> >> while running configure script. Also this might work on Windows where
> >> configure coupled with "make ctypes-python" might not.
> >
> >
> > That is not true.  setup.py is used to compile and clean the ctype-based Python bindings.
> 
> Yeah, and I think its use should be removed. distutils is overly
> complicated for what *should* be a very simple build/clean process.
> 
> Placing the output into the source directory (vs build) was just a
> simple mistake. There isn't any particular reason for that, I believe.

I've committed Noorul's patch in r1030557 because it fixes the build
problem and I don't know how to make ctypes-python find the file if we
generate it in the build dir.  That can be a later enhancement.

- Julian

Re: make check-ctypes-python fails when executed from non src build direction

Posted by Greg Stein <gs...@gmail.com>.
On Mon, Nov 1, 2010 at 13:22, Jeremy Whitlock <jc...@gmail.com> wrote:
>...
>>> subversion/bindings/ctypes-python/README still refers to setup.py.
>>
>> I think this is for those who are not using --with-ctypesgen option
>> while running configure script. Also this might work on Windows where
>> configure coupled with "make ctypes-python" might not.
>
>
> That is not true.  setup.py is used to compile and clean the ctype-based Python bindings.

Yeah, and I think its use should be removed. distutils is overly
complicated for what *should* be a very simple build/clean process.

Placing the output into the source directory (vs build) was just a
simple mistake. There isn't any particular reason for that, I believe.

Cheers,
-g

Re: make check-ctypes-python fails when executed from non src build direction

Posted by Jeremy Whitlock <jc...@gmail.com>.
On Nov 1, 2010, at 11:02 AM, Noorul Islam K M wrote:

> Daniel Shahaf <d....@daniel.shahaf.name> writes:
> 
>> Noorul Islam K M wrote on Mon, Nov 01, 2010 at 22:09:23 +0530:
>> 
>>> Julian Foad <ju...@wandisco.com> writes:
>>>> It looks like build_functions_py() expects to create functions.py in the
>>>> *source* directory, and build/run_ctypesgen.sh intentionally creates it
>>>> in the *build* directory.
>>> 
>>> I think setup.py is no longer used to generate bindings.
>>> 
>> 
>> subversion/bindings/ctypes-python/README still refers to setup.py.
> 
> I think this is for those who are not using --with-ctypesgen option
> while running configure script. Also this might work on Windows where
> configure coupled with "make ctypes-python" might not.


That is not true.  setup.py is used to compile and clean the ctype-based Python bindings.

Take care,

Jeremy Whitlock <jc...@gmail.com>
Twitter: jcscoobyrs
Website: http://www.thoughtspark.org

Re: make check-ctypes-python fails when executed from non src build direction

Posted by Noorul Islam K M <no...@collab.net>.
Daniel Shahaf <d....@daniel.shahaf.name> writes:

> Noorul Islam K M wrote on Mon, Nov 01, 2010 at 22:09:23 +0530:
>
>> Julian Foad <ju...@wandisco.com> writes:
>> > It looks like build_functions_py() expects to create functions.py in the
>> > *source* directory, and build/run_ctypesgen.sh intentionally creates it
>> > in the *build* directory.
>> 
>> I think setup.py is no longer used to generate bindings.
>> 
>
> subversion/bindings/ctypes-python/README still refers to setup.py.

I think this is for those who are not using --with-ctypesgen option
while running configure script. Also this might work on Windows where
configure coupled with "make ctypes-python" might not.

Thanks and Regards
Noorul