You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xylaaaaa (via GitHub)" <gi...@apache.org> on 2026/04/23 02:35:10 UTC
[PR] branch-4.1 [fix](build) Prefer thirdparty mirror for JuiceFS downloads [doris]
xylaaaaa opened a new pull request, #62732:
URL: https://github.com/apache/doris/pull/62732
## Summary
- prefer the datalake-owned mirror for JuiceFS Hadoop jar downloads in both docker and thirdparty build flows
- keep upstream Maven Central and JuiceFS GitHub release as the fallback path when the mirror is unavailable
- add shell regression coverage for the new default mirror path and fallback behavior
## Mirror Path
For branch-4.1, the default mirror is the Baidu Cloud BOS mirror:
- mirror root: `https://doris-thirdparty-repo.bj.bcebos.com/thirdparty`
The mirror can be customized via:
- `JUICEFS_THIRDPARTY_REPOSITORY_URL` environment variable
- `REPOSITORY_URL` environment variable
- `s3BucketName` + `s3Endpoint` for dynamic mirror construction
## Root Cause
JuiceFS downloads were hardcoded to Maven Central and GitHub release endpoints in the docker and thirdparty scripts. Network jitter on those upstream endpoints could stall or fail docker startup and thirdparty downloads.
## Impact
JuiceFS-related bootstrap paths now use the thirdparty mirror by default while preserving upstream fallback.
## Test Plan
- \`bash docker/thirdparties/test/juicefs-helpers-mirror-test.sh\`
- \`bash thirdparty/test/juicefs-default-mirror-test.sh\`
- \`bash thirdparty/test/download-thirdparty-fallback-test.sh\`
- \`bash -n docker/thirdparties/juicefs-helpers.sh thirdparty/vars.sh docker/thirdparties/test/juicefs-helpers-mirror-test.sh thirdparty/test/juicefs-default-mirror-test.sh thirdparty/test/download-thirdparty-fallback-test.sh\`
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Cherry-picked from #61968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1 [fix](build) Prefer thirdparty mirror for JuiceFS downloads [doris]
Posted by "xylaaaaa (via GitHub)" <gi...@apache.org>.
xylaaaaa commented on PR #62732:
URL: https://github.com/apache/doris/pull/62732#issuecomment-4301375606
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1 [fix](build) Prefer thirdparty mirror for JuiceFS downloads [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62732:
URL: https://github.com/apache/doris/pull/62732#issuecomment-4301966826
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62732_95f4a4dd6fb3c1b68c23345caa22c68199f0db73_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62732_95f4a4dd6fb3c1b68c23345caa22c68199f0db73_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.65% (26345/36770) |
| Line Coverage | 54.58% (279434/511946) |
| Region Coverage | 52.04% (232763/447298) |
| Branch Coverage | 53.33% (100449/188359) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1 [fix](build) Prefer thirdparty mirror for JuiceFS downloads [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #62732:
URL: https://github.com/apache/doris/pull/62732#discussion_r3128015005
##########
thirdparty/test/download-thirdparty-fallback-test.sh:
##########
@@ -0,0 +1,100 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -eo pipefail
+
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." &>/dev/null && pwd)"
+
Review Comment:
The PR description/test plan references `thirdparty/test/juicefs-default-mirror-test.sh`, but that script is not present in this branch (only `download-thirdparty-fallback-test.sh` exists under `thirdparty/test/`). Either add the missing test script(s) or update the PR description/test plan to match what’s actually included.
##########
thirdparty/vars.sh:
##########
@@ -548,7 +549,8 @@ JINDOFS_SOURCE=jindofs-6.10.4-libs-0.1
JINDOFS_MD5SUM="bd30b4c5fe97c4367eeb3bb228b317d9"
# juicefs
-JUICEFS_DOWNLOAD="https://repo1.maven.org/maven2/io/juicefs/juicefs-hadoop/1.3.1/juicefs-hadoop-1.3.1.jar"
+JUICEFS_DOWNLOAD="${DORIS_THIRDPARTY_REPOSITORY_URL%/}/juicefs-hadoop-1.3.1.jar"
+JUICEFS_FALLBACK_DOWNLOAD="https://repo1.maven.org/maven2/io/juicefs/juicefs-hadoop/1.3.1/juicefs-hadoop-1.3.1.jar"
Review Comment:
PR description says the mirror can be customized via `JUICEFS_THIRDPARTY_REPOSITORY_URL`, but the thirdparty build flow here hardcodes the default via `DORIS_THIRDPARTY_REPOSITORY_URL` (and only uses `REPOSITORY_URL` as a first-attempt URL). Consider aligning the env var name(s) across docker + thirdparty flows (e.g., also honoring `JUICEFS_THIRDPARTY_REPOSITORY_URL` here) or updating the PR description/docs so users know which variable applies to which flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1 [fix](build) Prefer thirdparty mirror for JuiceFS downloads [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #62732:
URL: https://github.com/apache/doris/pull/62732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] branch-4.1 [fix](build) Prefer thirdparty mirror for JuiceFS downloads [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62732:
URL: https://github.com/apache/doris/pull/62732#issuecomment-4301679902
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/95f4a4dd6fb3c1b68c23345caa22c68199f0db73_95f4a4dd6fb3c1b68c23345caa22c68199f0db73/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/95f4a4dd6fb3c1b68c23345caa22c68199f0db73_95f4a4dd6fb3c1b68c23345caa22c68199f0db73/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.29% (20017/37563) |
| Line Coverage | 36.72% (188613/513660) |
| Region Coverage | 33.07% (146598/443361) |
| Branch Coverage | 34.15% (64151/187837) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org