You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/04/12 23:29:23 UTC
zeppelin git commit: fix bugs for timer saver
Repository: zeppelin
Updated Branches:
refs/heads/master 35fa9d287 -> 902892a97
fix bugs for timer saver
### What is this PR for?
* add saveNote action when cron schedule setting in file notebook.controller.js
* case:
open one note\uff0cedit some text in a paragraph, then do a cron schedule setting, the content which just edited disappeared
* change invoke method for the timer saver in file paragraph.controller.js
* case:
open one browser\uff0cedit some text in a paragraph, then open the note in other browser\uff0cyou will find that the text you just edited did not be synced
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-2323](https://issues.apache.org/jira/browse/ZEPPELIN-2323)
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
Author: LeiWang <wa...@163.com>
Author: lei wang <le...@outlook.com>
Closes #2196 from wary/master and squashes the following commits:
b2ee2f9 [LeiWang] Update notebook.controller.js
2ab58c3 [LeiWang] Update notebook.controller.js
9908227 [LeiWang] Update paragraph.controller.js
3612f56 [lei wang] fix bugs for timer saver
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/902892a9
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/902892a9
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/902892a9
Branch: refs/heads/master
Commit: 902892a97723b0c4deb4ef832588067a0faa9d74
Parents: 35fa9d2
Author: LeiWang <wa...@163.com>
Authored: Sun Apr 9 19:01:46 2017 +0800
Committer: Lee moon soo <mo...@apache.org>
Committed: Thu Apr 13 08:29:17 2017 +0900
----------------------------------------------------------------------
.../src/app/notebook/paragraph/paragraph.controller.js | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/902892a9/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
index dbc6f4d..231ac0b 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@@ -129,15 +129,15 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
var initializeDefault = function(config) {
var forms = $scope.paragraph.settings.forms;
-
+
if (!config.colWidth) {
config.colWidth = 12;
}
-
+
if (config.enabled === undefined) {
config.enabled = true;
}
-
+
for (var idx in forms) {
if (forms[idx]) {
if (forms[idx].options) {
@@ -599,7 +599,7 @@ function ParagraphCtrl($scope, $rootScope, $route, $window, $routeParams, $locat
var session = editor.getSession();
var dirtyText = session.getValue();
$scope.dirtyText = dirtyText;
- $scope.$broadcast('startSaveTimer');
+ $scope.startSaveTimer();
setParagraphMode(session, dirtyText, editor.getCursorPosition());
};