You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/21 14:05:27 UTC

[GitHub] [spark] AngersZhuuuu commented on a diff in pull request #36943: [SPARK-39195][SQL][FOLLOWUP] Remove flaky test of OutputCommitCoordinator

AngersZhuuuu commented on code in PR #36943:
URL: https://github.com/apache/spark/pull/36943#discussion_r902665380


##########
core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorSuite.scala:
##########
@@ -144,13 +144,6 @@ class OutputCommitCoordinatorSuite extends SparkFunSuite with BeforeAndAfter {
     assert(tempDir.list().size === 1)
   }
 
-  test("If commit fails, if task is retried it should not be locked, and will succeed.") {

Review Comment:
   > do you know why it is flaky?
   
   The event in DAGScheduler is not stable,  TaskEnd of attempt 1 sometime's coming earlier then attempt 0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org