You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/10/30 06:16:34 UTC
[GitHub] [phoenix] virajjasani commented on a change in pull request #950: PHOENIX-5940 Pre-4.15 client cannot connect to 4.15+ server after SYS…
virajjasani commented on a change in pull request #950:
URL: https://github.com/apache/phoenix/pull/950#discussion_r514890776
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -3295,11 +3295,14 @@ public void getVersion(RpcController controller, GetVersionRequest request, RpcC
PhoenixDatabaseMetaData.SYSTEM_CATALOG_TABLE_BYTES, HConstants.LATEST_TIMESTAMP, null,
request.getClientVersion());
} catch (Throwable t) {
- LOGGER.error("loading system catalog table inside getVersion failed", t);
- ProtobufUtil.setControllerException(controller,
- ServerUtil.createIOException(
- SchemaUtil.getPhysicalTableName(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME_BYTES,
- isTablesMappingEnabled).toString(), t));
+ if (request.getClientVersion() >= MIN_SPLITTABLE_SYSTEM_CATALOG) {
+ LOGGER.error("loading system catalog table inside getVersion failed", t);
+ ProtobufUtil.setControllerException(controller,
+ ServerUtil.createIOException(
+ SchemaUtil.getPhysicalTableName(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME_BYTES,
+ isTablesMappingEnabled).toString(), t));
+ }
Review comment:
For else part, would it be better to just provide INFO log with client version and exact Exception that we are ignoring?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org