You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yhuai <gi...@git.apache.org> on 2016/05/25 23:34:14 UTC

[GitHub] spark pull request: [SPARK-15532] [SQL] Add SQLConf.ALLOW_MULTIPLE...

Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13310#discussion_r64671030
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -70,6 +70,27 @@ object SQLConf {
           .intConf
           .createWithDefault(10)
     
    +  val ALLOW_MULTIPLE_CONTEXTS = SQLConfigBuilder("spark.sql.allowMultipleContexts")
    +    .doc("When set to true, creating multiple SQLContexts/HiveContexts is allowed. " +
    +      "When set to false, only one SQLContext/HiveContext is allowed to be created " +
    +      "through the constructor (new SQLContexts/HiveContexts created through newSession " +
    +      "method is allowed). Please note that this conf needs to be set in Spark Conf. Once " +
    +      "a SQLContext/HiveContext has been created, changing the value of this conf will not " +
    +      "have effect.")
    +    .booleanConf
    +    .createWithDefault(false)
    +
    +  val ALLOW_MULTIPLE_CONTEXTS_ERROR_MESSAGE =
    +    SQLConfigBuilder("spark.sql.allowMultipleContexts.errorMessage")
    --- End diff --
    
    This name is not great. I am open to any suggestion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org