You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/18 12:57:48 UTC

[GitHub] [fineract] percyashu commented on a change in pull request #1184: FINERACT-1089 removing the rs.previous()

percyashu commented on a change in pull request #1184:
URL: https://github.com/apache/fineract/pull/1184#discussion_r472165457



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositAccountInterestRateChartReadPlatformServiceImpl.java
##########
@@ -305,12 +305,8 @@ public DepositAccountInterestRateChartSlabData extractData(ResultSet rs) throws
                     if (incentiveData != null) {
                         chartSlabData.addIncentives(incentiveData);
                     }
-                } else {
-                    rs.previous();

Review comment:
       @ptuomola concerning making extractData in to mapRow does this entails removing whole the rs.next() and using the ircIndex of the calling function as row number of the two RowMappers incentiveMapper and chartSlabsMapper.    




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org