You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by da...@apache.org on 2012/01/02 01:07:19 UTC
svn commit: r1226323 - /pig/trunk/test/org/apache/pig/test/TestPigRunner.java
Author: daijy
Date: Mon Jan 2 00:07:18 2012
New Revision: 1226323
URL: http://svn.apache.org/viewvc?rev=1226323&view=rev
Log:
Fix TestPigRunner.testErrorLogFile2 on nfs revealed by PIG-2291
Modified:
pig/trunk/test/org/apache/pig/test/TestPigRunner.java
Modified: pig/trunk/test/org/apache/pig/test/TestPigRunner.java
URL: http://svn.apache.org/viewvc/pig/trunk/test/org/apache/pig/test/TestPigRunner.java?rev=1226323&r1=1226322&r2=1226323&view=diff
==============================================================================
--- pig/trunk/test/org/apache/pig/test/TestPigRunner.java (original)
+++ pig/trunk/test/org/apache/pig/test/TestPigRunner.java Mon Jan 2 00:07:18 2012
@@ -124,9 +124,16 @@ public class TestPigRunner {
assertTrue(!stats.isSuccessful());
Properties props = stats.getPigProperties();
- String logfile = props.getProperty("pig.logfile");
- File f = new File(logfile);
- assertTrue(f.exists());
+ // If test on nfs, the pig script complaining "output" exists
+ // and does not actually launch the job. This could due to a mapreduce
+ // bug which removing file before closing it.
+ // If this happens, props is null because we only set pigContext before
+ // launching job.
+ if (props!=null) {
+ String logfile = props.getProperty("pig.logfile");
+ File f = new File(logfile);
+ assertTrue(f.exists());
+ }
} finally {
new File(PIG_FILE).delete();
}