You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ks...@apache.org on 2020/04/20 19:22:01 UTC

[arrow] 19/28: ARROW-8511: [Release] In verify-release-candidate.bat, exit when CMake build fails, use Unity build

This is an automated email from the ASF dual-hosted git repository.

kszucs pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git

commit 6f626af63b82ecf43a6f14b2311447bf7ac054fc
Author: Wes McKinney <we...@apache.org>
AuthorDate: Sun Apr 19 15:29:04 2020 -0500

    ARROW-8511: [Release] In verify-release-candidate.bat, exit when CMake build fails, use Unity build
    
    The unity build makes things faster, but it also hides the error reported in ARROW-8510. This at least allows the release verification to pass for 0.17.0
    
    Closes #6978 from wesm/ARROW-8511
    
    Authored-by: Wes McKinney <we...@apache.org>
    Signed-off-by: Wes McKinney <we...@apache.org>
---
 dev/release/verify-release-candidate.bat | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dev/release/verify-release-candidate.bat b/dev/release/verify-release-candidate.bat
index 1f99539..9b9ec8b 100644
--- a/dev/release/verify-release-candidate.bat
+++ b/dev/release/verify-release-candidate.bat
@@ -81,6 +81,7 @@ cmake -G "%GENERATOR%" ^
       -DARROW_BUILD_TESTS=ON ^
       -DGTest_SOURCE=BUNDLED ^
       -DCMAKE_BUILD_TYPE=%CONFIGURATION% ^
+      -DCMAKE_UNITY_BUILD=ON ^
       -DARROW_CXXFLAGS="/MP" ^
       -DARROW_WITH_BZ2=ON ^
       -DARROW_WITH_ZLIB=ON ^
@@ -94,7 +95,7 @@ cmake -G "%GENERATOR%" ^
       -DARROW_PARQUET=ON ^
       ..  || exit /B
 
-cmake --build . --target INSTALL --config Release
+cmake --build . --target INSTALL --config Release || exit /B 1
 
 @rem NOTE(wesm): Building googletest is flaky for me with ninja. Building it
 @rem first fixes the problem