You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by koone <gi...@git.apache.org> on 2016/11/11 10:08:44 UTC
[GitHub] incubator-eagle pull request #647: [EAGLE-740]Fix eagle-query checkstyle war...
GitHub user koone opened a pull request:
https://github.com/apache/incubator-eagle/pull/647
[EAGLE-740]Fix eagle-query checkstyle warnings
[EAGLE-740]Fix eagle-query checkstyle warnings
http://issues.apache.org/jira/browse/EAGLE-740
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/koone/incubator-eagle EAGLE-740
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/647.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #647
----
commit 42ebf7284e526e74b82e0c60e95515121f3d79f5
Author: koone <lu...@126.com>
Date: 2016-11-11T10:05:57Z
[EAGLE-740]Fix eagle-query checkstyle warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Posted by koone <gi...@git.apache.org>.
Github user koone commented on the issue:
https://github.com/apache/incubator-eagle/pull/647
@haoch the last commit is already roolback the code format
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/647
@koone As the PR changed too many files, please it may take a few days for reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/647
Could you please rollback the code format of files under `org.apache.eagle.query.antlr.generated` too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Posted by koone <gi...@git.apache.org>.
Github user koone commented on the issue:
https://github.com/apache/incubator-eagle/pull/647
revert eagle-antlr and exclude Classes under ` org.apache.eagle.query.antlr.generated` from checstyle
@haoch could you please check again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/647
Classes under `org.apache.eagle.query.antlr.generated` is automatically generated by `antlr`, so suggest to exclude it from checkstyle and keep the original code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #647: [EAGLE-740]Fix eagle-query checkstyle warnings
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/647
@koone thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---