[GitHub] [druid] cryptoe commented on a diff in pull request #12358: apache-rat-plugin license checker always break on website artifacts.

[GitBox <gi...@apache.org>]

cryptoe commented on code in PR #12358:
URL: https://github.com/apache/druid/pull/12358#discussion_r863980405


##########
pom.xml:
##########
@@ -1838,6 +1838,8 @@
                                 <exclude>.editorconfig</exclude>
                                 <exclude>**/hadoop.indexer.libs.version</exclude>
                                 <exclude>**/codegen/**</exclude>
+                                <exclude>website/target/**</exclude>

Review Comment:
   @didip My question is more around the error message you got without these properties supplied. The PR description claims that the apache-rat plugin always breaks which then points to that all druid builds will always fail no?
   
   cause we have the below step in the pipeline.
   ```
   - name: "license checks"
         install: skip
         before_script: &setup_generate_license
           - sudo apt-get update && sudo apt-get install python3 python3-pip python3-setuptools -y
           - ./check_test_suite.py && travis_terminate 0 || echo 'Continuing setup'
           - pip3 install wheel  # install wheel first explicitly
           - pip3 install pyyaml==5.4.1
         script:
           - >
             ${MVN} apache-rat:check -Prat --fail-at-end
             -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
             -Drat.consoleOutput=true
           # Generate dependency reports and checks they are valid. When running on Travis CI, 2 cores are available
           # (https://docs.travis-ci.com/user/reference/overview/#virtualisation-environment-vs-operating-system).
           - mkdir -p target
           - distribution/bin/generate-license-dependency-reports.py . target --clean-maven-artifact-transfer --parallel 2
           - distribution/bin/check-licenses.py licenses.yaml target/license-reports
           ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org