[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4170: Make realtime server upload timeout configurable

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4170: Make realtime server upload timeout configurable
URL: https://github.com/apache/incubator-pinot/pull/4170#discussion_r279090092
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
 ##########
 @@ -135,7 +135,7 @@ public String segmentConsumed(@QueryParam(SegmentCompletionProtocol.PARAM_INSTAN
 
     SegmentCompletionProtocol.Response response = _segmentCompletionManager.segmentConsumed(requestParams);
     final String responseStr = response.toJsonString();
-    LOGGER.info("Response to segmentConsumed:{}", responseStr);
+    LOGGER.info("Response to segmentConsumed for segment {} is :{}", segmentName, responseStr);
 
 Review comment:
   Suggest changing the message to: "Response to segmentConsumed for segment: '{}' is: {}"
   (Add single quote around segment name so we know if there are leading or trailing spaces, also for the ':', no space before and one space after)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org