You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hudi-bot (via GitHub)" <gi...@apache.org> on 2025/11/30 11:02:49 UTC

[I] Improve TestSimpleSchemaConflictResolutionStrategy [hudi]

hudi-bot opened a new issue, #16705:
URL: https://github.com/apache/hudi/issues/16705

   Right now TestSimpleSchemaConflictResolutionStrategy extends SimpleSchemaConflictResolutionStrategy due to the limitation of test mocks.  This should be improved so that TestSimpleSchemaConflictResolutionStrategy does not extend SimpleSchemaConflictResolutionStrategy.
   {code:java}
   public class TestSimpleSchemaConflictResolutionStrategy extends SimpleSchemaConflictResolutionStrategy {code}
   
   ## JIRA info
   
   - Link: https://issues.apache.org/jira/browse/HUDI-8443
   - Type: Improvement
   - Fix version(s):
     - 1.1.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Improve TestSimpleSchemaConflictResolutionStrategy [hudi]

Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 commented on issue #16705:
URL: https://github.com/apache/hudi/issues/16705#issuecomment-4892601929

   This issue was reviewed as part of the JIRA-migrated backlog triage.
   
   Findings: The current `TestSimpleSchemaConflictResolutionStrategy` no longer extends `SimpleSchemaConflictResolutionStrategy`. On `master` (and in the 1.0.2 / 1.1.0 release lines) it is a plain `public class TestSimpleSchemaConflictResolutionStrategy { ... }` that uses Mockito `@Mock` fields (e.g. mocked `config`, `viewManager`, `engineContext`) and holds the strategy as a mocked collaborator rather than subclassing it — exactly the improvement requested here. This mock-based form was introduced with PR #12781.
   
   If you're still seeing the old subclass-based form on a recent version, please reopen with details.
   
   Closing as fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Improve TestSimpleSchemaConflictResolutionStrategy [hudi]

Posted by "deepakpanda93 (via GitHub)" <gi...@apache.org>.
deepakpanda93 closed issue #16705: Improve TestSimpleSchemaConflictResolutionStrategy
URL: https://github.com/apache/hudi/issues/16705


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org