[jira] (MCHANGES-303) Add an option to enable tls

["Dennis Lundberg (JIRA)" <ji...@codehaus.org>]

    [ https://jira.codehaus.org/browse/MCHANGES-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=343062#comment-343062 ] 

Dennis Lundberg commented on MCHANGES-303:
------------------------------------------

Hello Benoit,

Thank you for your patch. I've had a look at it and it looks good, but I have a question.

In the ProjectJavamailMailSender.java file you set the {{startTls}} property if TLS is enabled. Shouldn't  that code be inside the try/catch just above it? I.e. inside the {{if( isSslMode() )}} statement? I imagine that SSL is required to be able to use TLS.

> Add an option to enable tls
> ---------------------------
>
>                 Key: MCHANGES-303
>                 URL: https://jira.codehaus.org/browse/MCHANGES-303
>             Project: Maven Changes Plugin
>          Issue Type: Improvement
>          Components: announcement
>    Affects Versions: 2.8
>            Reporter: Benoit Guerin
>         Attachments: enableTls.patch
>
>
> Add an option to set ProjectJavamailMailSender.tlsEnabled to true, to allow to use as an example GMail to send announcement emails



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)