You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 17:55:22 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request #351: Only register Flight.proto with cargo if it exists
tustvold opened a new pull request #351:
URL: https://github.com/apache/arrow-rs/pull/351
# Which issue does this PR close?
Closes #350.
Experimentation suggests if you "register" a file that doesn't exist with cargo:rerun-if-changed, it will always re-compile the crate. My hope is that this will resolve #350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #351: Only register Flight.proto with cargo if it exists
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #351:
URL: https://github.com/apache/arrow-rs/pull/351#issuecomment-848286155
The MIRI failure is unrelated to this PR: https://github.com/apache/arrow-rs/issues/345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #351: Only register Flight.proto with cargo if it exists
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #351:
URL: https://github.com/apache/arrow-rs/pull/351#issuecomment-848101872
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#351](https://codecov.io/gh/apache/arrow-rs/pull/351?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d5777ce) into [master](https://codecov.io/gh/apache/arrow-rs/commit/488f82663d507baef6eb75e7bbbb9708ced3f9a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (488f826) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head d5777ce differs from pull request most recent head a729b6e. Consider uploading reports for the commit a729b6e to get more accurate results
[](https://codecov.io/gh/apache/arrow-rs/pull/351?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 82.56% 82.56%
=======================================
Files 162 162
Lines 44063 44063
=======================================
Hits 36379 36379
Misses 7684 7684
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/351?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/351?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [488f826...a729b6e](https://codecov.io/gh/apache/arrow-rs/pull/351?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] nevi-me merged pull request #351: Only register Flight.proto with cargo if it exists
Posted by GitBox <gi...@apache.org>.
nevi-me merged pull request #351:
URL: https://github.com/apache/arrow-rs/pull/351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org