You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/11 03:27:37 UTC
Review Request 62878: Sent CheckpointResourcesMessage only when
reregister with an old master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62878/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Joseph Wu, and Jan Schlicht.
Bugs: MESOS-8058
https://issues.apache.org/jira/browse/MESOS-8058
Repository: mesos
Description
-------
No need for sending checkpoint resources message to the agent if the
master does not have state about the agent.
Diffs
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
Diff: https://reviews.apache.org/r/62878/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 62878: Sent CheckpointResourcesMessage only when
reregister with an old master.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62878/#review187803
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Oct. 11, 2017, 5:27 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62878/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2017, 5:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> No need for sending checkpoint resources message to the agent if the
> master does not have state about the agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
>
>
> Diff: https://reviews.apache.org/r/62878/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62878: Sent CheckpointResourcesMessage only when
reregister with an old master.
Posted by Jie Yu <yu...@gmail.com>.
> On Oct. 25, 2017, 12:43 a.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 6321-6355 (patched)
> > <https://reviews.apache.org/r/62878/diff/3/?file=1861968#file1861968line6322>
> >
> > As discussed offline, I think it makes sense to put this block in `reconcileKnownAgent`, as you previously suggested. I see no reason not to do it in this patch, but one of us could follow up with another patch as well.
Yeah, I'll follow up with another patch.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62878/#review189089
-----------------------------------------------------------
On Oct. 17, 2017, 11:24 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62878/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 11:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> No need for sending checkpoint resources message to the agent if the
> master does not have state about the agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
>
>
> Diff: https://reviews.apache.org/r/62878/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62878: Sent CheckpointResourcesMessage only when
reregister with an old master.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62878/#review189089
-----------------------------------------------------------
src/master/master.cpp
Lines 6321-6355 (patched)
<https://reviews.apache.org/r/62878/#comment266009>
As discussed offline, I think it makes sense to put this block in `reconcileKnownAgent`, as you previously suggested. I see no reason not to do it in this patch, but one of us could follow up with another patch as well.
- Greg Mann
On Oct. 17, 2017, 11:24 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62878/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 11:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> No need for sending checkpoint resources message to the agent if the
> master does not have state about the agent.
>
>
> Diffs
> -----
>
> src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
>
>
> Diff: https://reviews.apache.org/r/62878/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62878: Sent CheckpointResourcesMessage only when
reregister with an old master.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62878/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 11:24 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Joseph Wu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-8058
https://issues.apache.org/jira/browse/MESOS-8058
Repository: mesos
Description
-------
No need for sending checkpoint resources message to the agent if the
master does not have state about the agent.
Diffs (updated)
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
Diff: https://reviews.apache.org/r/62878/diff/3/
Changes: https://reviews.apache.org/r/62878/diff/2-3/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 62878: Sent CheckpointResourcesMessage only when
reregister with an old master.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62878/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 6:59 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Joseph Wu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-8058
https://issues.apache.org/jira/browse/MESOS-8058
Repository: mesos
Description
-------
No need for sending checkpoint resources message to the agent if the
master does not have state about the agent.
Diffs (updated)
-----
src/master/master.cpp 3603878f02ae3dba82811a4a5770dd21ec790ef6
Diff: https://reviews.apache.org/r/62878/diff/2/
Changes: https://reviews.apache.org/r/62878/diff/1-2/
Testing
-------
make check
Thanks,
Jie Yu