You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Felix Meschberger <fm...@adobe.com> on 2011/02/05 00:16:25 UTC

New Parent POM (Re: FELIX-1747)

Hi all,

At long last I have now committed the changes to the Felix parent POM
described in FELIX-1747 [1]. Along with this I have committed changes to
the Configuration Admin (configadmin) and Declarative Services (scr)
projects to use this new parent POM.

To see, what this parent POM is all about with respect to releasing look
particularly at these things in the configadmin and scr projects:

  * Extensions to precanned LICENSE, NOTICE, and DEPENDENCIES files
     can be provided in the src/main/appended-resources folder. See
     the scr project for an example

  * To see the outcome of a release build run the following mvn
    command:
      $ mvn -Papache-release clean verify
    This will build the project run all tests, generate artifacts
    for releasing, checks files with the RAT plugin and uses the IANAL
    plugin to verify the presence of required legal files.

WDYT ?

Next step -- if we would want to pursue this -- would be to release the
new parent POM and start converting the projects ...

Regards
Felix

[1] https://issues.apache.org/jira/browse/FELIX-1747


Re: New Parent POM (Re: FELIX-1747)

Posted by Felix Meschberger <fm...@adobe.com>.
Hi Clément,

Am Sonntag, den 06.02.2011, 15:01 +0000 schrieb Clement Escoffier: 
> Hi,
> 
> I've looked a little bit more deeper into the new pom, and got several
> issues / comments:
> - RAT: the current rat configuration do not allow inherited project to
> configure the configuration. This is rather annoying when you have more to
> exclude.

Any clue how to fix this ? I like to have a default setup but I
understand your requirement for a per-project overwrite/refinement

> - Legal files into src/main/appended-resources: I'm not against, but when
> I open a project, I generally expect to get the legal files in the root.
> At the same time, I also expect to find those files in META-INF in jar
> files.

Upon (release) build they will be placed into META-INF.

The files in src/main/appended-resources are not complete -- for example
the ASL2 license is not there as it will be brought in by the remote
resources plugin.

I think at the end of the day it is just getting used to it...


> - ianal: This is definitely great. I just have one issue. It does not
> check for 3rd-party license. For example in SCR, you should probably have
> the license.kxml2 as you're embedding it (OBR does
> ).

Yes, it does not validate 3rd party licenses. In traditional maven
projects the 3rd party licenses would be collected through the
dependency maven poms providing <license> elements.

In our OSGi projects using the bundle plugin to embed 3rd party
libraries this has to be done and checked manually.

Plus: as per Apache policy all 3rd licenses must be placed in the
LICENSE file.

Regards
Felix

> 
> Regards,
> 
> Clement
> 
> On 05.02.11 00:16, "Felix Meschberger" <fm...@adobe.com> wrote:
> 
> >Hi all,
> >
> >At long last I have now committed the changes to the Felix parent POM
> >described in FELIX-1747 [1]. Along with this I have committed changes to
> >the Configuration Admin (configadmin) and Declarative Services (scr)
> >projects to use this new parent POM.
> >
> >To see, what this parent POM is all about with respect to releasing look
> >particularly at these things in the configadmin and scr projects:
> >
> >  * Extensions to precanned LICENSE, NOTICE, and DEPENDENCIES files
> >     can be provided in the src/main/appended-resources folder. See
> >     the scr project for an example
> >
> >  * To see the outcome of a release build run the following mvn
> >    command:
> >      $ mvn -Papache-release clean verify
> >    This will build the project run all tests, generate artifacts
> >    for releasing, checks files with the RAT plugin and uses the IANAL
> >    plugin to verify the presence of required legal files.
> >
> >WDYT ?
> >
> >Next step -- if we would want to pursue this -- would be to release the
> >new parent POM and start converting the projects ...
> >
> >Regards
> >Felix
> >
> >[1] https://issues.apache.org/jira/browse/FELIX-1747
> >
> 
> 



Re: New Parent POM (Re: FELIX-1747)

Posted by Clement Escoffier <cl...@gmail.com>.
Hi,

I've looked a little bit more deeper into the new pom, and got several
issues / comments:
- RAT: the current rat configuration do not allow inherited project to
configure the configuration. This is rather annoying when you have more to
exclude.
- Legal files into src/main/appended-resources: I'm not against, but when
I open a project, I generally expect to get the legal files in the root.
At the same time, I also expect to find those files in META-INF in jar
files.
- ianal: This is definitely great. I just have one issue. It does not
check for 3rd-party license. For example in SCR, you should probably have
the license.kxml2 as you're embedding it (OBR does).

Regards,

Clement

On 05.02.11 00:16, "Felix Meschberger" <fm...@adobe.com> wrote:

>Hi all,
>
>At long last I have now committed the changes to the Felix parent POM
>described in FELIX-1747 [1]. Along with this I have committed changes to
>the Configuration Admin (configadmin) and Declarative Services (scr)
>projects to use this new parent POM.
>
>To see, what this parent POM is all about with respect to releasing look
>particularly at these things in the configadmin and scr projects:
>
>  * Extensions to precanned LICENSE, NOTICE, and DEPENDENCIES files
>     can be provided in the src/main/appended-resources folder. See
>     the scr project for an example
>
>  * To see the outcome of a release build run the following mvn
>    command:
>      $ mvn -Papache-release clean verify
>    This will build the project run all tests, generate artifacts
>    for releasing, checks files with the RAT plugin and uses the IANAL
>    plugin to verify the presence of required legal files.
>
>WDYT ?
>
>Next step -- if we would want to pursue this -- would be to release the
>new parent POM and start converting the projects ...
>
>Regards
>Felix
>
>[1] https://issues.apache.org/jira/browse/FELIX-1747
>



Re: New Parent POM (Re: FELIX-1747)

Posted by Clement Escoffier <cl...@gmail.com>.
Hi,

On 05.02.11 00:16, "Felix Meschberger" <fm...@adobe.com> wrote:

>Hi all,
>
>At long last I have now committed the changes to the Felix parent POM
>described in FELIX-1747 [1]. Along with this I have committed changes to
>the Configuration Admin (configadmin) and Declarative Services (scr)
>projects to use this new parent POM.
>
>To see, what this parent POM is all about with respect to releasing look
>particularly at these things in the configadmin and scr projects:
>
>  * Extensions to precanned LICENSE, NOTICE, and DEPENDENCIES files
>     can be provided in the src/main/appended-resources folder. See
>     the scr project for an example
>
>  * To see the outcome of a release build run the following mvn
>    command:
>      $ mvn -Papache-release clean verify
>    This will build the project run all tests, generate artifacts
>    for releasing, checks files with the RAT plugin and uses the IANAL
>    plugin to verify the presence of required legal files.
>
>WDYT ?

It is really good ! I will give it a try on iPOJO.

As we're modifying the parent pom, we also should fix the maven 3
'issues'. I've already committed the wagon-ssh extension. So we should
select the plugin version we want to use to make maven 3 happy (most of
the report plugins require maven 3, but who use the reports?).

Regards,

Clement

>
>Next step -- if we would want to pursue this -- would be to release the
>new parent POM and start converting the projects ...
>
>Regards
>Felix
>
>[1] https://issues.apache.org/jira/browse/FELIX-1747
>