You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/07/11 12:25:45 UTC
[GitHub] [openwhisk-deploy-kube] style95 opened a new pull request, #733: Add permission to the events
style95 opened a new pull request, #733:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/733
This is the counterpart of this PR https://github.com/apache/openwhisk/pull/5270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] ningyougang merged pull request #733: Add permission to the events
Posted by GitBox <gi...@apache.org>.
ningyougang merged PR #733:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] ningyougang commented on a diff in pull request #733: Add permission to the events
Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #733:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/733#discussion_r921825392
##########
helm/openwhisk/templates/invoker-role.yaml:
##########
@@ -34,6 +34,9 @@ rules:
- apiGroups: [""]
resources: ["pods"]
verbs: ["get", "list", "watch", "create", "update", "patch", "delete"]
+- apiGroups: [""]
+ resources: ["events"]
+ verbs: ["get", "list"]
Review Comment:
Seems our downstream doesn't have this changes,
So we changed the events k8s resource's permission manually?
##########
helm/openwhisk/templates/invoker-role.yaml:
##########
@@ -34,6 +34,9 @@ rules:
- apiGroups: [""]
resources: ["pods"]
verbs: ["get", "list", "watch", "create", "update", "patch", "delete"]
+- apiGroups: [""]
+ resources: ["events"]
+ verbs: ["get", "list"]
Review Comment:
Seems our downstream doesn't have this changes
So we changed the events k8s resource's permission manually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] ningyougang commented on a diff in pull request #733: Add permission to the events
Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #733:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/733#discussion_r921830352
##########
helm/openwhisk/templates/invoker-role.yaml:
##########
@@ -34,6 +34,9 @@ rules:
- apiGroups: [""]
resources: ["pods"]
verbs: ["get", "list", "watch", "create", "update", "patch", "delete"]
+- apiGroups: [""]
+ resources: ["events"]
+ verbs: ["get", "list"]
Review Comment:
Our downstream use another invoker-role.yaml which already applied above configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-deploy-kube] ningyougang commented on a diff in pull request #733: Add permission to the events
Posted by GitBox <gi...@apache.org>.
ningyougang commented on code in PR #733:
URL: https://github.com/apache/openwhisk-deploy-kube/pull/733#discussion_r921825392
##########
helm/openwhisk/templates/invoker-role.yaml:
##########
@@ -34,6 +34,9 @@ rules:
- apiGroups: [""]
resources: ["pods"]
verbs: ["get", "list", "watch", "create", "update", "patch", "delete"]
+- apiGroups: [""]
+ resources: ["events"]
+ verbs: ["get", "list"]
Review Comment:
Seems our downstream doesn't have this change.
So we changed the events k8s resource's permission manually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org