You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by "mawiesne (via GitHub)" <gi...@apache.org> on 2023/06/13 05:52:33 UTC

[GitHub] [opennlp-addons] mawiesne opened a new pull request, #14: OpenNLP-1496 Migrate opennlp-addons to Java 17 LTS

mawiesne opened a new pull request, #14:
URL: https://github.com/apache/opennlp-addons/pull/14

   Change
   -
   - updates addon components to use opennlp-tools version 2.2.1-SNAPSHOT
   - adjusts GH actions config dropping Java 11
   
   Tasks
   -
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn clean install` at the root opennlp-sandbox folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](https://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp-sandbox folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp-sandbox folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp-addons] mawiesne commented on pull request #14: OpenNLP-1496 Migrate opennlp-addons to Java 17 LTS

Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on PR #14:
URL: https://github.com/apache/opennlp-addons/pull/14#issuecomment-1588590316

   @rzo1 / @jzonthemtn / @kinow I opened this Draft PR to verify addons are fine with migration to Java 17. Once we got a next OpenNLP release ready, I will adjust this branch/PR so it uses a stable OpenNLP version, instead of a SNAPSHOT build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp-addons] mawiesne merged pull request #14: OpenNLP-1496 Migrate opennlp-addons to Java 17 LTS

Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne merged PR #14:
URL: https://github.com/apache/opennlp-addons/pull/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp-addons] mawiesne commented on pull request #14: OpenNLP-1496 Migrate opennlp-addons to Java 17 LTS

Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on PR #14:
URL: https://github.com/apache/opennlp-addons/pull/14#issuecomment-1685093172

   @rzo1 / @jzonthemtn / @kinow PR is ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [opennlp-addons] kinow commented on pull request #14: OpenNLP-1496 Migrate opennlp-addons to Java 17 LTS

Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #14:
URL: https://github.com/apache/opennlp-addons/pull/14#issuecomment-1685112310

   Thank you @mawiesne !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org