You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/01 09:58:36 UTC

[GitHub] [cloudstack] shwstppr commented on a change in pull request #4135: Remove use of blacklist/whitelist terms

shwstppr commented on a change in pull request #4135:
URL: https://github.com/apache/cloudstack/pull/4135#discussion_r567694815



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-410to420.sql
##########
@@ -2065,7 +2065,7 @@ alter table `cloud`.`vpc_gateways` add column network_acl_id bigint unsigned def
 update `cloud`.`vpc_gateways` set network_acl_id = 2;
 
 
-INSERT IGNORE INTO `cloud`.`configuration` VALUES ('Advanced', 'DEFAULT', 'VpcManager', 'blacklisted.routes', NULL, 'Routes that are blacklisted, can not be used for Static Routes creation for the VPC Private Gateway');
+INSERT IGNORE INTO `cloud`.`configuration` VALUES ('Advanced', 'DEFAULT', 'VpcManager', 'blacklisted.routes', NULL, 'Routes that are denied, can not be used for Static Routes creation for the VPC Private Gateway');

Review comment:
       4.16 now. Also, we are not changing name for this config and just the description? `blacklisted.routes`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org