You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/27 14:41:54 UTC

[GitHub] [hudi] vinothchandar opened a new pull request #3726: [MINOR] Add a RFC template and folder

vinothchandar opened a new pull request #3726:
URL: https://github.com/apache/hudi/pull/3726


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-929251190


   Ok I think I understood. rfc-number is a substitution of the new rfc number


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar merged pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #3726:
URL: https://github.com/apache/hudi/pull/3726


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-928184950


   @vinothchandar RFCs should be kept in asf-site? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-929234706






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-929234706


   Readme is common for all PRS right. Why would We need a copy per PR? Sorry, not following fully. let me also read the other PR comments fully.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-927945227


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f1b58045603fec113b12eba78884f6e9ad98d929",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f1b58045603fec113b12eba78884f6e9ad98d929",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f1b58045603fec113b12eba78884f6e9ad98d929 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-927945227


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f1b58045603fec113b12eba78884f6e9ad98d929",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2433",
       "triggerID" : "f1b58045603fec113b12eba78884f6e9ad98d929",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f1b58045603fec113b12eba78884f6e9ad98d929 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2433) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar merged pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #3726:
URL: https://github.com/apache/hudi/pull/3726


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-929271177


   Addressed all feedback on other PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan edited a comment on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
xushiyan edited a comment on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-928184950


   ~@vinothchandar RFCs should be kept in asf-site?~ Read the process PR and understood the idea. Yes looks easier to keep PRs and RFC docs updated altogether. And RFCs may not be appropriate to be published on website.
   
   Just as suggested in the other PR, the template MD file can be moved to `rfc/rfc-<number>/README.md` for segregating files and easy browsing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-927943161


   templates for #3725 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-928184950


   @vinothchandar RFCs should be kept in asf-site? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan edited a comment on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
xushiyan edited a comment on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-928184950


   @vinothchandar ~RFCs should be kept in asf-site?~ ok just read the process PR and understood the idea. Yes looks easier to keep PRs and RFC docs updated altogether. And RFCs may not be appropriate to be published on website.
   
   Just as suggested in the other PR, the template MD file can be moved to `rfc/rfc-<number>/README.md` for segregating files and easy browsing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan edited a comment on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
xushiyan edited a comment on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-928184950






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3726: [MINOR] Add a RFC template and folder

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3726:
URL: https://github.com/apache/hudi/pull/3726#issuecomment-927945227


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f1b58045603fec113b12eba78884f6e9ad98d929",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2433",
       "triggerID" : "f1b58045603fec113b12eba78884f6e9ad98d929",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f1b58045603fec113b12eba78884f6e9ad98d929 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2433) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org