[GitHub] [fineract] ruchiD commented on a diff in pull request #3090: FINERACT-1724-Last-repayment-amount-date-closed-overpaid-loans

["ruchiD (via GitHub)" <gi...@apache.org>]

ruchiD commented on code in PR #3090:
URL: https://github.com/apache/fineract/pull/3090#discussion_r1157040762


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanBusinessEventSerializer.java:
##########
@@ -68,6 +68,9 @@ protected <T> ByteBufferSerializable toAvroDTO(BusinessEvent<T> rawEvent) {
         if (data.isActive()) {
             CollectionData delinquentData = delinquencyReadPlatformService.calculateLoanCollectionData(loanId);
             data.setDelinquent(delinquentData);
+        } else {
+            CollectionData delinquentData = delinquencyReadPlatformService.retrieveLoanLastRepaymentData(loanId);

Review Comment:
   Fixed. I thought only lastRepaymentDate and amount was required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org