You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2012/11/05 16:34:12 UTC

[jira] [Created] (SLING-2650) Speed up JcrPropertyMapCacheEntry

Marcel Reutegger created SLING-2650:
---------------------------------------

             Summary: Speed up JcrPropertyMapCacheEntry
                 Key: SLING-2650
                 URL: https://issues.apache.org/jira/browse/SLING-2650
             Project: Sling
          Issue Type: Improvement
          Components: JCR
    Affects Versions: JCR Resource 2.1.0
            Reporter: Marcel Reutegger
            Priority: Minor
         Attachments: SLING-2650.patch

JcrPropertyMapCacheEntry (as well as JcrResourceUtil) retrieve the PropertyDefinition to find out whether a Property is multi-valued or not. At least in Apache Jackrabbit and Apache Oak this is more expensive than simply calling Property.isMultiple() because it has to evaluate node type information.

Both JcrPropertyMapCacheEntry and JcrResourceUtil should rather use the method on Property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2650) Speed up JcrPropertyMapCacheEntry

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger updated SLING-2650:
------------------------------------

    Attachment: SLING-2650.patch

Proposed changes.
                
> Speed up JcrPropertyMapCacheEntry
> ---------------------------------
>
>                 Key: SLING-2650
>                 URL: https://issues.apache.org/jira/browse/SLING-2650
>             Project: Sling
>          Issue Type: Improvement
>          Components: JCR
>    Affects Versions: JCR Resource 2.1.0
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: SLING-2650.patch
>
>
> JcrPropertyMapCacheEntry (as well as JcrResourceUtil) retrieve the PropertyDefinition to find out whether a Property is multi-valued or not. At least in Apache Jackrabbit and Apache Oak this is more expensive than simply calling Property.isMultiple() because it has to evaluate node type information.
> Both JcrPropertyMapCacheEntry and JcrResourceUtil should rather use the method on Property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SLING-2650) Speed up JcrPropertyMapCacheEntry

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-2650.
-------------------------------------

    Resolution: Fixed

Thanks Marcel, I've applied your patch 
                
> Speed up JcrPropertyMapCacheEntry
> ---------------------------------
>
>                 Key: SLING-2650
>                 URL: https://issues.apache.org/jira/browse/SLING-2650
>             Project: Sling
>          Issue Type: Improvement
>          Components: JCR
>    Affects Versions: JCR Resource 2.1.0
>            Reporter: Marcel Reutegger
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: JCR Resource 2.1.2
>
>         Attachments: SLING-2650.patch
>
>
> JcrPropertyMapCacheEntry (as well as JcrResourceUtil) retrieve the PropertyDefinition to find out whether a Property is multi-valued or not. At least in Apache Jackrabbit and Apache Oak this is more expensive than simply calling Property.isMultiple() because it has to evaluate node type information.
> Both JcrPropertyMapCacheEntry and JcrResourceUtil should rather use the method on Property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2650) Speed up JcrPropertyMapCacheEntry

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler updated SLING-2650:
------------------------------------

    Fix Version/s: JCR Resource 2.1.2
    
> Speed up JcrPropertyMapCacheEntry
> ---------------------------------
>
>                 Key: SLING-2650
>                 URL: https://issues.apache.org/jira/browse/SLING-2650
>             Project: Sling
>          Issue Type: Improvement
>          Components: JCR
>    Affects Versions: JCR Resource 2.1.0
>            Reporter: Marcel Reutegger
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: JCR Resource 2.1.2
>
>         Attachments: SLING-2650.patch
>
>
> JcrPropertyMapCacheEntry (as well as JcrResourceUtil) retrieve the PropertyDefinition to find out whether a Property is multi-valued or not. At least in Apache Jackrabbit and Apache Oak this is more expensive than simply calling Property.isMultiple() because it has to evaluate node type information.
> Both JcrPropertyMapCacheEntry and JcrResourceUtil should rather use the method on Property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (SLING-2650) Speed up JcrPropertyMapCacheEntry

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler reassigned SLING-2650:
---------------------------------------

    Assignee: Carsten Ziegeler
    
> Speed up JcrPropertyMapCacheEntry
> ---------------------------------
>
>                 Key: SLING-2650
>                 URL: https://issues.apache.org/jira/browse/SLING-2650
>             Project: Sling
>          Issue Type: Improvement
>          Components: JCR
>    Affects Versions: JCR Resource 2.1.0
>            Reporter: Marcel Reutegger
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>         Attachments: SLING-2650.patch
>
>
> JcrPropertyMapCacheEntry (as well as JcrResourceUtil) retrieve the PropertyDefinition to find out whether a Property is multi-valued or not. At least in Apache Jackrabbit and Apache Oak this is more expensive than simply calling Property.isMultiple() because it has to evaluate node type information.
> Both JcrPropertyMapCacheEntry and JcrResourceUtil should rather use the method on Property.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira