You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/06 04:22:11 UTC
[jira] [Commented] (BEAM-413) Mean$CountSum tests for floating
point equality
[ https://issues.apache.org/jira/browse/BEAM-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363740#comment-15363740 ]
ASF GitHub Bot commented on BEAM-413:
-------------------------------------
GitHub user lucasallan opened a pull request:
https://github.com/apache/incubator-beam/pull/591
[BEAM-413] - Improves test for floating point equality.
This operation compares two floating point values for equality. Because
floating point calculations may involve rounding, calculated float and
double values may not be accurate. For values that must be precise, such
as monetary values, consider using a fixed-precision type such as
BigDecimal. For values that need not be precise, consider comparing for
equality within some range, for example: if ( Math.abs(x - y) < .0000001
).
For more information: https://issues.apache.org/jira/browse/BEAM-413
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lucasallan/incubator-beam beam-413
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #591
----
commit 231a93ef16e781c01a33947f3c9a3173eaeba899
Author: Lucas Amorim <lu...@lucass-mbp.hitronhub.home>
Date: 2016-07-06T04:19:08Z
[BEAM-413] - Improves test for floating point equality.
This operation compares two floating point values for equality. Because
floating point calculations may involve rounding, calculated float and
double values may not be accurate. For values that must be precise, such
as monetary values, consider using a fixed-precision type such as
BigDecimal. For values that need not be precise, consider comparing for
equality within some range, for example: if ( Math.abs(x - y) < .0000001
).
For more information: https://issues.apache.org/jira/browse/BEAM-413
----
> Mean$CountSum tests for floating point equality
> -----------------------------------------------
>
> Key: BEAM-413
> URL: https://issues.apache.org/jira/browse/BEAM-413
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs FE_FLOATING_POINT_EQUALITY|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L298]: Test for floating point equality
> Applies to: [Mean$CountSum.equals|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Mean.java#L165].
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)