You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/03 02:00:25 UTC
[GitHub] [iceberg] sungwy opened a new issue, #4952: Use of ANSI SQL reserved key word 'key' in JdbcUtil.java
sungwy opened a new issue, #4952:
URL: https://github.com/apache/iceberg/issues/4952
The word 'key' is used as a column name for the metadata table 'iceberg_namespace_properties' in the current implementation of Iceberg's JDBC Catalog. This is a reserved keyword according to ANSI SQL standards, and hence such schema would cause issues in ANSI SQL compliant databases.
https://github.com/apache/iceberg/blob/e40705de5d7bfdf36466a961ca517d5e55d99bf0/core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java#L83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on issue #4952: Use of ANSI SQL reserved key word 'key' in JdbcUtil.java
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #4952:
URL: https://github.com/apache/iceberg/issues/4952#issuecomment-1150147877
@sungwy, if this hasn't been released yet, then let's fix it. Can you open a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] sungwy commented on issue #4952: Use of ANSI SQL reserved key word 'key' in JdbcUtil.java
Posted by GitBox <gi...@apache.org>.
sungwy commented on issue #4952:
URL: https://github.com/apache/iceberg/issues/4952#issuecomment-1150145883
@felixYyu @nssalian @rdblue
Hello folks! Just wanted to tag you to see if you had any thoughts on this issue.
At the very least I think we could expect companies using managed SQL infrastructures with varying degrees in strictness of lint checks getting unnecessary noise or failures from having to deal with a reserved key word as a column.
It doesn't look like this change has made it to a release yet, but other open source projects are already looking into onboarding this implementation, so it would be good to understand whether this schema will be staying for good, or it might be worth changing this now.
https://github.com/trinodb/trino/pull/11772/files#diff-e4db49a223035ceaad88fc346e7558b55ff83485ac36bf92e97409b36ceb9717R102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on issue #4952: Use of ANSI SQL reserved key word 'key' in JdbcUtil.java
Posted by GitBox <gi...@apache.org>.
kbendick commented on issue #4952:
URL: https://github.com/apache/iceberg/issues/4952#issuecomment-1154170386
As #5017 has been merged and the field has been renamed, I’m going to close this issue.
Please create a new issue if there’s a new question, or reopen this issue if the follow up relates directly to the field name (or potentially open a new isssue that references this one).
Thank you for reporting @sungwy and thank you for the patch @syun64!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick closed issue #4952: Use of ANSI SQL reserved key word 'key' in JdbcUtil.java
Posted by GitBox <gi...@apache.org>.
kbendick closed issue #4952: Use of ANSI SQL reserved key word 'key' in JdbcUtil.java
URL: https://github.com/apache/iceberg/issues/4952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on issue #4952: Use of ANSI SQL reserved key word 'key' in JdbcUtil.java
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #4952:
URL: https://github.com/apache/iceberg/issues/4952#issuecomment-1150156129
Great, thank you for doing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] sungwy commented on issue #4952: Use of ANSI SQL reserved key word 'key' in JdbcUtil.java
Posted by GitBox <gi...@apache.org>.
sungwy commented on issue #4952:
URL: https://github.com/apache/iceberg/issues/4952#issuecomment-1150153301
Sure thing - I am doing this work as a part of a company, so I will raise a ticket for Open Source contribution, and open the PR soon on the company account. Will keep you posted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org