You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by guzzijason <gi...@git.apache.org> on 2017/07/11 21:33:44 UTC
[GitHub] incubator-trafficcontrol pull request #724: [TC-416] tomcat init script fixe...
GitHub user guzzijason opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/724
[TC-416] tomcat init script fixes for traffic_router
Improving the reliabitiy of STOPPING tomcat service.
1. Add following variables to init script:
SHUTDOWN_TIMEOUT (default 10 seconds)
SHUTDOWN_FORCE (default "true" - kill if the shutdown times out)
2. Only export $CATALINA_OPTS when needed (to start the server)
Tomcat control scripts do this fun thing where to stop the current
jvm, catalina *starts* a second jvm, which then tells the first
to stop. This is all well and good, except we really don't want
to start this second jvm with our custom $CATALINA_OPTS, especially
on servers under memory pressure!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guzzijason/incubator-trafficcontrol tomcat-init
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/724.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #724
----
commit 77d92d9ff0b60f0d372186f7c607de806e73ca19
Author: Jason Tucker <ja...@comcast.com>
Date: 2017-07-11T20:59:32Z
tomcat init script fixes for traffic_router
Improving the reliabitiy of STOPPING tomcat service.
1. Add following variables to init script:
SHUTDOWN_TIMEOUT (default 10 seconds)
SHUTDOWN_FORCE (default "true" - kill if the shutdown times out)
2. Only export $CATALINA_OPTS when needed (to start the server)
Tomcat control scripts do this fun thing where to stop the current
jvm, catalina *starts* a second jvm, which then tells the first
to stop. This is all well and good, except we really don't want
to start this second jvm with our custom $CATALINA_OPTS, especially
on servers under memory pressure!
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #724: [TC-416] tomcat init script fixe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/724
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---