[GitHub] [ignite] nizhikov commented on a change in pull request #9628: IGNITE-14299 .NET: Support BinaryArrays in services

[GitBox <gi...@apache.org>]

nizhikov commented on a change in pull request #9628:
URL: https://github.com/apache/ignite/pull/9628#discussion_r765992107



##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxyInvoker.cs
##########
@@ -102,6 +102,12 @@ internal static class ServiceProxyInvoker
                         methodName, svcType, argsLength));
 
             // 2) There is more than 1 method with specified name - resolve with argument types.
+            methods = methods.Where(m => AreMethodArgsCompatible(arguments, m.GetParameters(), true)).ToArray();

Review comment:
       `ServicesClientTestBinaryArrays#testOverloadResolution` failed without changes with exception: 
   > Apache.Ignite.Core.Client.IgniteClientException : Failed to invoke proxy: there are 2 methods 'Foo' in type 
   > 'Apache.Ignite.Core.Tests.Client.Services.TestServiceOverloads' with (Person[]) arguments, can't resolve ambiguity.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org