You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/01/23 09:00:32 UTC

[GitHub] [incubator-inlong] imvan opened a new pull request #2287: [INLONG-2161][Feature][Manager] Define the sort_cluster_config table of getClusterConfig interface

imvan opened a new pull request #2287:
URL: https://github.com/apache/incubator-inlong/pull/2287


   ### Title Name: [INLONG-2161][component] Define the sort_cluster_config table
   
   
   Fixes #2161
   
   ### Motivation
   
   Define sort_cluster_config table. 
   Use cluster name to select the corresponding tasks and the sink type of each task.
   
   ### Modifications
   
   Add mappers of sort_cluster_config
   Add invalid cluster name check.
   Add UT of blank cluster name
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #2287: [INLONG-2161][Feature][Manager] add the sort_cluster_config table for getClusterConfig interface

Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #2287:
URL: https://github.com/apache/incubator-inlong/pull/2287#discussion_r790272885



##########
File path: inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/entity/SortClusterConfgiEntity.java
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.dao.entity;
+
+import lombok.Data;
+
+import java.io.Serializable;
+
+@Data
+public class SortClusterConfgiEntity implements Serializable {
+    private Integer id;
+    private String clusterName;
+    private String taskName;
+    private String sinkType;
+    private static final long serialVersionUID = 1L;

Review comment:
       serialVersionUID is invalid.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] codecov-commenter commented on pull request #2287: [INLONG-2161][Feature][Manager] Define the sort_cluster_config table of getClusterConfig interface

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2287:
URL: https://github.com/apache/incubator-inlong/pull/2287#issuecomment-1019443938


   # [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2287](https://codecov.io/gh/apache/incubator-inlong/pull/2287?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8aa65dc) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/2dbfa280c2c78b2144c9e984bdb3f275b3eba9a1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dbfa28) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/2287/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/2287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #2287   +/-   ##
   =========================================
     Coverage     12.54%   12.54%           
     Complexity     1217     1217           
   =========================================
     Files           420      420           
     Lines         36235    36229    -6     
     Branches       5674     5670    -4     
   =========================================
     Hits           4545     4545           
   + Misses        30881    30875    -6     
     Partials        809      809           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/2287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...rg/apache/inlong/tubemq/server/tools/CliUtils.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci90b29scy9DbGlVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...apache/inlong/tubemq/server/broker/TubeBroker.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9icm9rZXIvVHViZUJyb2tlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...pache/inlong/tubemq/server/master/utils/Chore.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9tYXN0ZXIvdXRpbHMvQ2hvcmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ache/inlong/tubemq/server/tools/BdbGroupAdmin.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci90b29scy9CZGJHcm91cEFkbWluLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...he/inlong/tubemq/server/tools/cli/CliConsumer.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci90b29scy9jbGkvQ2xpQ29uc3VtZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...he/inlong/tubemq/server/tools/cli/CliProducer.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci90b29scy9jbGkvQ2xpUHJvZHVjZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/inlong/tubemq/server/tools/StoreRepairAdmin.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci90b29scy9TdG9yZVJlcGFpckFkbWluLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...inlong/tubemq/server/tools/cli/CliBrokerAdmin.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci90b29scy9jbGkvQ2xpQnJva2VyQWRtaW4uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ng/tubemq/server/master/web/common/BaseResult.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL2NvbW1vbi9CYXNlUmVzdWx0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...bemq/server/broker/msgstore/disk/MsgFileStore.java](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9icm9rZXIvbXNnc3RvcmUvZGlzay9Nc2dGaWxlU3RvcmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-inlong/pull/2287/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2287?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/2287?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2dbfa28...8aa65dc](https://codecov.io/gh/apache/incubator-inlong/pull/2287?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] dockerzhang merged pull request #2287: [INLONG-2161][Feature][Manager] add the sort_cluster_config table for getClusterConfig interface

Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2287:
URL: https://github.com/apache/incubator-inlong/pull/2287


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #2287: [INLONG-2161][Feature][Manager] add the sort_cluster_config table for getClusterConfig interface

Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #2287:
URL: https://github.com/apache/incubator-inlong/pull/2287#discussion_r790273042



##########
File path: inlong-manager/manager-dao/src/main/resources/generatorConfig.xml
##########
@@ -210,7 +210,14 @@
                 enableUpdateByPrimaryKey="true"
                 enableDeleteByPrimaryKey="true" enableInsert="true"
                 enableCountByExample="false" enableDeleteByExample="false"
-                enableSelectByExample="false" enableUpdateByExample="false"/>-->
+                enableSelectByExample="false" enableUpdateByExample="false"/>
+
+        <table tableName="sort_cluster_config" domainObjectName="SortClusterConfgiEntity"
+               enableSelectByPrimaryKey="true"
+               enableUpdateByPrimaryKey="true"
+               enableDeleteByPrimaryKey="true" enableInsert="true"
+               enableCountByExample="false" enableDeleteByExample="false"
+               enableSelectByExample="false" enableUpdateByExample="false"/>-->

Review comment:
       Please remove unuse code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org