You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2010/01/08 18:52:54 UTC
[jira] Created: (HDFS-883) Datanode shutdown should log problems
with Storage.unlockAll()
Datanode shutdown should log problems with Storage.unlockAll()
--------------------------------------------------------------
Key: HDFS-883
URL: https://issues.apache.org/jira/browse/HDFS-883
Project: Hadoop HDFS
Issue Type: Improvement
Components: data-node
Affects Versions: 0.22.0
Reporter: Steve Loughran
Assignee: Steve Loughran
Priority: Minor
When shutting down, Datanode calls {{Storage.unlockAll()}}, but discards any exceptions thrown in the process.
These exceptions could be useful in diagnosing problems, and should be logged.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-883) Datanode shutdown should log problems
with Storage.unlockAll()
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805008#action_12805008 ]
Steve Loughran commented on HDFS-883:
-------------------------------------
As I said in the patch; no tests here as all that is happening is logging shutdown problems that are fairly hard to simulate, but when they happen, should at least be logged
> Datanode shutdown should log problems with Storage.unlockAll()
> --------------------------------------------------------------
>
> Key: HDFS-883
> URL: https://issues.apache.org/jira/browse/HDFS-883
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HDFS-883.patch
>
>
> When shutting down, Datanode calls {{Storage.unlockAll()}}, but discards any exceptions thrown in the process.
> These exceptions could be useful in diagnosing problems, and should be logged.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-883) Datanode shutdown should log problems
with Storage.unlockAll()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798236#action_12798236 ]
Hadoop QA commented on HDFS-883:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12429766/HDFS-883.patch
against trunk revision 897068.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/90/console
This message is automatically generated.
> Datanode shutdown should log problems with Storage.unlockAll()
> --------------------------------------------------------------
>
> Key: HDFS-883
> URL: https://issues.apache.org/jira/browse/HDFS-883
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HDFS-883.patch
>
>
> When shutting down, Datanode calls {{Storage.unlockAll()}}, but discards any exceptions thrown in the process.
> These exceptions could be useful in diagnosing problems, and should be logged.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-883) Datanode shutdown should log problems
with Storage.unlockAll()
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HDFS-883:
----------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Fix Version/s: 0.22.0
Resolution: Fixed
I just committed this. Thanks Steve.
> Datanode shutdown should log problems with Storage.unlockAll()
> --------------------------------------------------------------
>
> Key: HDFS-883
> URL: https://issues.apache.org/jira/browse/HDFS-883
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-883.patch
>
>
> When shutting down, Datanode calls {{Storage.unlockAll()}}, but discards any exceptions thrown in the process.
> These exceptions could be useful in diagnosing problems, and should be logged.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (HDFS-883) Datanode shutdown should log
problems with Storage.unlockAll()
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HDFS-883 started by Steve Loughran.
> Datanode shutdown should log problems with Storage.unlockAll()
> --------------------------------------------------------------
>
> Key: HDFS-883
> URL: https://issues.apache.org/jira/browse/HDFS-883
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
>
> When shutting down, Datanode calls {{Storage.unlockAll()}}, but discards any exceptions thrown in the process.
> These exceptions could be useful in diagnosing problems, and should be logged.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-883) Datanode shutdown should log problems
with Storage.unlockAll()
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HDFS-883:
--------------------------------
Status: Patch Available (was: In Progress)
> Datanode shutdown should log problems with Storage.unlockAll()
> --------------------------------------------------------------
>
> Key: HDFS-883
> URL: https://issues.apache.org/jira/browse/HDFS-883
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HDFS-883.patch
>
>
> When shutting down, Datanode calls {{Storage.unlockAll()}}, but discards any exceptions thrown in the process.
> These exceptions could be useful in diagnosing problems, and should be logged.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-883) Datanode shutdown should log problems
with Storage.unlockAll()
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HDFS-883:
--------------------------------
Attachment: HDFS-883.patch
Patch logs at warn level. No tests, not unless someone starts simulating storage failures.
{code}
try {
this.storage.unlockAll();
} catch (IOException ie) {
+ LOG.warn("Exception when unlocking storage: " + ie,
+ ie);
}
}
{code}
> Datanode shutdown should log problems with Storage.unlockAll()
> --------------------------------------------------------------
>
> Key: HDFS-883
> URL: https://issues.apache.org/jira/browse/HDFS-883
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HDFS-883.patch
>
>
> When shutting down, Datanode calls {{Storage.unlockAll()}}, but discards any exceptions thrown in the process.
> These exceptions could be useful in diagnosing problems, and should be logged.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.