You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/11/10 21:39:18 UTC
svn commit: r1769202 - in /jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
xdocs/changes.xml
Author: pmouawad
Date: Thu Nov 10 21:39:18 2016
New Revision: 1769202
URL: http://svn.apache.org/viewvc?rev=1769202&view=rev
Log:
Bug 60360 - View Result Tree : Request Tab does not show body of a DELETE request
Bugzilla Id: 60360
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java?rev=1769202&r1=1769201&r2=1769202&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java Thu Nov 10 21:39:18 2016
@@ -40,8 +40,10 @@ public class HTTPSampleResult extends Sa
/** Set of all HTTP methods, that have no body */
private static final Set<String> METHODS_WITHOUT_BODY = new HashSet<>(
- Arrays.asList(HTTPConstants.GET, HTTPConstants.HEAD,
- HTTPConstants.OPTIONS, HTTPConstants.DELETE,
+ Arrays.asList(
+ HTTPConstants.GET,
+ HTTPConstants.HEAD,
+ HTTPConstants.OPTIONS,
HTTPConstants.TRACE));
private String cookies = ""; // never null
@@ -148,7 +150,7 @@ public class HTTPSampleResult extends Sa
sb.append(' ');
sb.append(u.toString());
sb.append('\n');
- // Include request body if it is a post or put or patch
+ // Include request body if it can have one
if (!METHODS_WITHOUT_BODY.contains(method)) {
sb.append("\n").append(method).append(" data:\n");
sb.append(queryString);
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1769202&r1=1769201&r2=1769202&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Thu Nov 10 21:39:18 2016
@@ -226,7 +226,6 @@ The HTML source code in the Results Tree
<h3>I18N</h3>
<ul>
<li><pr>214</pr>Add spanish translation for delayed starting of threads. Contributed by Asier Lostal� (asier.lostale at openbravo.com).</li>
- <li><bug>60348</bug>Change chinese translation for <code>Save as</code>. Contributed by XMeter (support at xmeter.net).</li>
</ul>
<h3>Report / Dashboard</h3>
@@ -310,6 +309,7 @@ The HTML source code in the Results Tree
<li><bug>59712</bug>Display original query in RequestView when decoding fails. Based on a patch by
Teemu Vesala (teemu.vesala at qentinel.com)</li>
<li><bug>60278</bug>Since 2.13 (and <bugzilla>57514</bugzilla>), Aggregate Graph, Summary Report and Aggregate Report lost precision in the Error, Rate and Bandwidth values saved in the saved file csv</li>
+ <li><bug>60360</bug>View Result Tree : Request Tab does not show body of a DELETE request</li>
</ul>
<h3>Timers, Assertions, Config, Pre- & Post-Processors</h3>
@@ -373,7 +373,6 @@ The HTML source code in the Results Tree
<li>Roberto Braga (roberto.braga at soziale.it)</li>
<li>jarek102 at gmail.com</li>
<li>Wyatt Epp (wyatt.epp at gmail.com)</li>
-<li>XMeter (support at xmeter.net)</li>
</ul>
<p>We also thank bug reporters who helped us improve JMeter. <br/>
For this release we want to give special thanks to the following reporters for the clear reports and tests made after our fixes:</p>
Re: svn commit: r1769202 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
xdocs/changes.xml
Posted by Philippe Mouawad <ph...@gmail.com>.
On Friday, November 11, 2016, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
>
>
> Am 11. November 2016 10:50:39 MEZ, schrieb Philippe Mouawad <
> philippe.mouawad@gmail.com <javascript:;>>:
> >Sorry Felix,
> >Just a mistake.
> >I'll fix it or feel free to do it.
>
> I will not be able to do so before tomorrow.
>
> >
> >Did you have time to review last commits and the patch for GET with
> >body ?
>
> No. The intention is to enable body with get requests, right?
Yes. Maybe I could make the patch activable per temp property to reduce
risk.
On only use entity if there is a body.
>
> Felix
>
> >Thanks
> >Regards
> >
> >On Friday, November 11, 2016, Felix Schumacher <
> >felix.schumacher@internetallee.de <javascript:;>> wrote:
> >
> >>
> >>
> >> Am 10. November 2016 22:39:18 MEZ, schrieb pmouawad@apache.org
> <javascript:;>
> >> <javascript:;>:
> >> >Author: pmouawad
> >> >Date: Thu Nov 10 21:39:18 2016
> >> >New Revision: 1769202
> >> >
> >> >URL: http://svn.apache.org/viewvc?rev=1769202&view=rev
> >> >Log:
> >> >Bug 60360 - View Result Tree : Request Tab does not show body of a
> >> >DELETE request
> >> >Bugzilla Id: 60360
> >> >
> >> >Modified:
> >>
> >>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
> >> HTTPSampleResult.java
> >> > jmeter/trunk/xdocs/changes.xml
> >> >
> >> >Modified:
> >>
> >>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
> >> HTTPSampleResult.java
> >> >URL:
> >> >http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/
> >>
> >http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java?rev=
> >> 1769202&r1=1769201&r2=1769202&view=diff
> >> >===========================================================
> >> ===================
> >> >---
> >>
> >>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
> >> HTTPSampleResult.java
> >> >(original)
> >> >+++
> >>
> >>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
> >> HTTPSampleResult.java
> >> >Thu Nov 10 21:39:18 2016
> >> >@@ -40,8 +40,10 @@ public class HTTPSampleResult extends Sa
> >> >
> >> > /** Set of all HTTP methods, that have no body */
> >> > private static final Set<String> METHODS_WITHOUT_BODY = new
> >HashSet<>(
> >> ...
> >> >
> >> >Modified: jmeter/trunk/xdocs/changes.xml
> >> >URL:
> >> >http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
> >> xml?rev=1769202&r1=1769201&r2=1769202&view=diff
> >> >===========================================================
> >> ===================
> >> >--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
> >> >+++ jmeter/trunk/xdocs/changes.xml
> >> ...
> >> >- <li><bug>60348</bug>Change chinese translation for <code>Save
> >> >as</code>. Contributed by XMeter (support at xmeter.net).</li>
> >>
> >> Any reason to drop this part?
> >>
> >> Regards,
> >> Felix
> >>
> >>
> >>
> >>
>
>
--
Cordialement.
Philippe Mouawad.
Re: svn commit: r1769202 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java xdocs/changes.xml
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 11. November 2016 10:50:39 MEZ, schrieb Philippe Mouawad <ph...@gmail.com>:
>Sorry Felix,
>Just a mistake.
>I'll fix it or feel free to do it.
I will not be able to do so before tomorrow.
>
>Did you have time to review last commits and the patch for GET with
>body ?
No. The intention is to enable body with get requests, right?
Felix
>Thanks
>Regards
>
>On Friday, November 11, 2016, Felix Schumacher <
>felix.schumacher@internetallee.de> wrote:
>
>>
>>
>> Am 10. November 2016 22:39:18 MEZ, schrieb pmouawad@apache.org
>> <javascript:;>:
>> >Author: pmouawad
>> >Date: Thu Nov 10 21:39:18 2016
>> >New Revision: 1769202
>> >
>> >URL: http://svn.apache.org/viewvc?rev=1769202&view=rev
>> >Log:
>> >Bug 60360 - View Result Tree : Request Tab does not show body of a
>> >DELETE request
>> >Bugzilla Id: 60360
>> >
>> >Modified:
>>
>>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
>> HTTPSampleResult.java
>> > jmeter/trunk/xdocs/changes.xml
>> >
>> >Modified:
>>
>>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
>> HTTPSampleResult.java
>> >URL:
>> >http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/
>>
>http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java?rev=
>> 1769202&r1=1769201&r2=1769202&view=diff
>> >===========================================================
>> ===================
>> >---
>>
>>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
>> HTTPSampleResult.java
>> >(original)
>> >+++
>>
>>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
>> HTTPSampleResult.java
>> >Thu Nov 10 21:39:18 2016
>> >@@ -40,8 +40,10 @@ public class HTTPSampleResult extends Sa
>> >
>> > /** Set of all HTTP methods, that have no body */
>> > private static final Set<String> METHODS_WITHOUT_BODY = new
>HashSet<>(
>> ...
>> >
>> >Modified: jmeter/trunk/xdocs/changes.xml
>> >URL:
>> >http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
>> xml?rev=1769202&r1=1769201&r2=1769202&view=diff
>> >===========================================================
>> ===================
>> >--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
>> >+++ jmeter/trunk/xdocs/changes.xml
>> ...
>> >- <li><bug>60348</bug>Change chinese translation for <code>Save
>> >as</code>. Contributed by XMeter (support at xmeter.net).</li>
>>
>> Any reason to drop this part?
>>
>> Regards,
>> Felix
>>
>>
>>
>>
Re: svn commit: r1769202 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
xdocs/changes.xml
Posted by Philippe Mouawad <ph...@gmail.com>.
Sorry Felix,
Just a mistake.
I'll fix it or feel free to do it.
Did you have time to review last commits and the patch for GET with body ?
Thanks
Regards
On Friday, November 11, 2016, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:
>
>
> Am 10. November 2016 22:39:18 MEZ, schrieb pmouawad@apache.org
> <javascript:;>:
> >Author: pmouawad
> >Date: Thu Nov 10 21:39:18 2016
> >New Revision: 1769202
> >
> >URL: http://svn.apache.org/viewvc?rev=1769202&view=rev
> >Log:
> >Bug 60360 - View Result Tree : Request Tab does not show body of a
> >DELETE request
> >Bugzilla Id: 60360
> >
> >Modified:
> >jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
> HTTPSampleResult.java
> > jmeter/trunk/xdocs/changes.xml
> >
> >Modified:
> >jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
> HTTPSampleResult.java
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/
> http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java?rev=
> 1769202&r1=1769201&r2=1769202&view=diff
> >===========================================================
> ===================
> >---
> >jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
> HTTPSampleResult.java
> >(original)
> >+++
> >jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/
> HTTPSampleResult.java
> >Thu Nov 10 21:39:18 2016
> >@@ -40,8 +40,10 @@ public class HTTPSampleResult extends Sa
> >
> > /** Set of all HTTP methods, that have no body */
> > private static final Set<String> METHODS_WITHOUT_BODY = new HashSet<>(
> ...
> >
> >Modified: jmeter/trunk/xdocs/changes.xml
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
> xml?rev=1769202&r1=1769201&r2=1769202&view=diff
> >===========================================================
> ===================
> >--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
> >+++ jmeter/trunk/xdocs/changes.xml
> ...
> >- <li><bug>60348</bug>Change chinese translation for <code>Save
> >as</code>. Contributed by XMeter (support at xmeter.net).</li>
>
> Any reason to drop this part?
>
> Regards,
> Felix
>
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: svn commit: r1769202 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java xdocs/changes.xml
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 10. November 2016 22:39:18 MEZ, schrieb pmouawad@apache.org:
>Author: pmouawad
>Date: Thu Nov 10 21:39:18 2016
>New Revision: 1769202
>
>URL: http://svn.apache.org/viewvc?rev=1769202&view=rev
>Log:
>Bug 60360 - View Result Tree : Request Tab does not show body of a
>DELETE request
>Bugzilla Id: 60360
>
>Modified:
>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
> jmeter/trunk/xdocs/changes.xml
>
>Modified:
>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java?rev=1769202&r1=1769201&r2=1769202&view=diff
>==============================================================================
>---
>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
>(original)
>+++
>jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
>Thu Nov 10 21:39:18 2016
>@@ -40,8 +40,10 @@ public class HTTPSampleResult extends Sa
>
> /** Set of all HTTP methods, that have no body */
> private static final Set<String> METHODS_WITHOUT_BODY = new HashSet<>(
...
>
>Modified: jmeter/trunk/xdocs/changes.xml
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1769202&r1=1769201&r2=1769202&view=diff
>==============================================================================
>--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
>+++ jmeter/trunk/xdocs/changes.xml
...
>- <li><bug>60348</bug>Change chinese translation for <code>Save
>as</code>. Contributed by XMeter (support at xmeter.net).</li>
Any reason to drop this part?
Regards,
Felix